Summary: | An XMLDocument interface should be exposed on the global Window object | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, buildbot, commit-queue, rniwa, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
URL: | https://dom.spec.whatwg.org/#xmldocument | ||||||||||||||
Attachments: |
|
Description
Chris Dumez
2016-01-22 15:12:58 PST
Created attachment 269638 [details]
WIP Patch
Comment on attachment 269638 [details] WIP Patch Attachment 269638 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/728068 New failing tests: http/tests/security/cross-frame-access-put.html svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html Created attachment 269653 [details]
Archive of layout-test-results from ews101 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 269638 [details] WIP Patch Attachment 269638 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/728053 New failing tests: http/tests/security/cross-frame-access-put.html svg/custom/manually-parsed-embedded-svg-allowed-in-dashboard.html http/tests/xmlhttprequest/svg-created-by-xhr-allowed-in-dashboard.html Created attachment 269654 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #6) > Previously WONTFIX'ed in bug 36465. DOM spec now defines XMLDocument: https://dom.spec.whatwg.org/#xmldocument I don't quite understand the purpose of it though... Created attachment 269678 [details]
Patch
Corresponding Chromium revision / bugs: - https://src.chromium.org/viewvc/blink?revision=165607&view=revision - https://code.google.com/p/chromium/issues/detail?id=238366 - https://code.google.com/p/chromium/issues/detail?id=238372 Firefox doc: https://developer.mozilla.org/en-US/docs/Web/API/XMLDocument (In reply to comment #7) > (In reply to comment #6) > > Previously WONTFIX'ed in bug 36465. > > DOM spec now defines XMLDocument: https://dom.spec.whatwg.org/#xmldocument > > I don't quite understand the purpose of it though... It seems part of the reason why XMLDocument exists is to expose load() to XMLDocuments (but not HTML ones): https://html.spec.whatwg.org/#dom-xmldocument-load We don't seem to implement Document.load() at the moment. That said, other browsers have XMLDocument, it is in the HTML / DOM specs, it is covered by standards compliance tests, and it is not much effort or code to support it. Comment on attachment 269678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269678&action=review > Source/WebCore/dom/DOMImplementation.idl:40 > + [ObjCLegacyUnnamedParameters, RaisesException] Document createDocument([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI, > + [TreatNullAs=NullString, Default=Undefined] optional DOMString qualifiedName, > + [TreatNullAs=NullString, Default=Undefined] optional DocumentType doctype); So wordy, and yet many these properties like TreatNullAs and Default aren’t even used by ObjC and GObject bindings. > Source/WebCore/dom/DOMImplementation.idl:44 > + [RaisesException, NewObject] XMLDocument createDocument([TreatNullAs=NullString, TreatUndefinedAs=NullString, Default=Undefined] optional DOMString namespaceURI, > [TreatNullAs=NullString, Default=Undefined] optional DOMString qualifiedName, > [TreatNullAs=NullString, Default=Undefined] optional DocumentType doctype); Indentation seems random. > Source/WebCore/dom/XMLDocument.h:48 > + XMLDocument(Frame* frame, const URL& url, unsigned documentClasses) > + : Document(frame, url, documentClasses) > + { } Seems like this constructor should either do: : Document(frame, url, XMLDocumentClass | documentClasses) or: ASSERT(documentClasses & XMLDocumentClass); Created attachment 269706 [details]
Patch
Comment on attachment 269706 [details] Patch Clearing flags on attachment: 269706 Committed r195520: <http://trac.webkit.org/changeset/195520> All reviewed patches have been landed. Closing bug. |