Bug 15337

Summary: Efficiently handle regexp property identifiers for 19% speedup on Celtic Kane regexp test
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: JavaScriptCoreAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
URL: http://celtickane.com/projects/jsspeed2007.php
Attachments:
Description Flags
speedup patch mrowe: review+

Maciej Stachowiak
Reported 2007-10-01 22:13:59 PDT
The Celtic Kane regexp benchmark spends a lot of its time making Identifiers for a lot of the custom properties kept on RegExp related objects. It would work much better to use the CommonIdentifiers technique for these.
Attachments
speedup patch (5.40 KB, patch)
2007-10-01 22:52 PDT, Maciej Stachowiak 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2007-10-01 22:52:28 PDT
Created attachment 16495 [details] speedup patch
Mark Rowe (bdash)
Comment 2 2007-10-02 02:24:25 PDT
Comment on attachment 16495 [details] speedup patch r=me
Note You need to log in before you can comment on or make changes to this bug.