Bug 153360

Summary:

Add support for testing data detection.

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

Tools / Tests

Assignee:

Enrica Casucci <enrica>

Status:

REOPENED ---

Severity:

Normal

CC:

lforschler, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Enrica Casucci 2016-01-22 10:52:11 PST

We want to be able to test data detection with our testing infrastructure.

Comment 1 Enrica Casucci 2016-01-22 10:57:08 PST

Created attachment 269584 [details]
Patch

Comment 2 Tim Horton 2016-01-22 13:17:09 PST

Comment on attachment 269584 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269584&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:111
> +    if (m_options.useDataDetection)

I think you should just do this in TestControllerCocoa.mm's platformCreateWebView and then you can only do it in one place. We might want to make a thing that takes the globalWebViewConfiguration and modifies it given a set of TestOptions so that we can do the same thing in platformCreateOtherPage too.

Comment 3 Enrica Casucci 2016-01-22 14:17:56 PST

Committed revision 195474.

Comment 4 Ryan Haddad 2016-01-22 14:32:28 PST

This change appears to have broken the 32-bit Mac build:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%2832-bit%20Build%29/builds/2739>

/Volumes/Data/slave/elcapitan-32bit-release/build/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:30: error: instance method '-setDataDetectorTypes:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
/Volumes/Data/slave/elcapitan-32bit-release/build/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:51: error: use of undeclared identifier 'WKDataDetectorTypeAll'