Bug 153360

Summary: Add support for testing data detection.
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: Tools / TestsAssignee: Enrica Casucci <enrica>
Status: REOPENED    
Severity: Normal CC: lforschler, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Enrica Casucci
Reported 2016-01-22 10:52:11 PST
We want to be able to test data detection with our testing infrastructure.
Attachments
Patch (3.86 KB, patch)
2016-01-22 10:57 PST, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-01-22 10:57:08 PST
Created attachment 269584 [details] Patch
Tim Horton
Comment 2 2016-01-22 13:17:09 PST
Comment on attachment 269584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269584&action=review > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:111 > + if (m_options.useDataDetection) I think you should just do this in TestControllerCocoa.mm's platformCreateWebView and then you can only do it in one place. We might want to make a thing that takes the globalWebViewConfiguration and modifies it given a set of TestOptions so that we can do the same thing in platformCreateOtherPage too.
Enrica Casucci
Comment 3 2016-01-22 14:17:56 PST
Committed revision 195474.
Ryan Haddad
Comment 4 2016-01-22 14:32:28 PST
This change appears to have broken the 32-bit Mac build: <https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20%2832-bit%20Build%29/builds/2739> /Volumes/Data/slave/elcapitan-32bit-release/build/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:30: error: instance method '-setDataDetectorTypes:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access] /Volumes/Data/slave/elcapitan-32bit-release/build/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:84:51: error: use of undeclared identifier 'WKDataDetectorTypeAll'
Note You need to log in before you can comment on or make changes to this bug.