Summary: | Fix the !ENABLE(INDEXED_DATABASE) build after r195443 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | achristensen, beidson, commit-queue, ossy | ||||
Priority: | P1 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 153318 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2016-01-22 02:17:43 PST
Created attachment 269561 [details]
Patch for landing
just to document, build logs can be found here: - https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53084 - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/75280 Otherwise please check the EWS before landing and the waterfall after landing a patch to avoid build breaks. Comment on attachment 269561 [details] Patch for landing Clearing flags on attachment: 269561 Committed r195449: <http://trac.webkit.org/changeset/195449> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > just to document, build logs can be found here: > - https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53084 > - > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 75280 > > Otherwise please check the EWS before landing and the > waterfall after landing a patch to avoid build breaks. EWS was in epically bad shape last night due to the server spitting 503s and having to be rebooted, and the commit queue is actually what landed this patch. I've been tooting this horn for years now - If we are going to rely on tools, the tools have to actually do the job perfectly (or at least better than an attentive person would). And they are far from that standard. See: The Automation Paradox. Sorry about the break and thanks for the fix. |