Bug 153318

Summary:

Modern IDB: Support populating/extracting database metadata with SQLite backend

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, ossy, rniwa

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

153319, 153350

Bug Blocks:

149117, 153021

Attachments:

Description	Flags
Patch v1	achristensen: review+, buildbot: commit-queue-
Patch for landing	commit-queue: commit-queue-
Archive of layout-test-results from ews116 for mac-yosemite	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Patch for landing 2	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews112 for mac-yosemite	none
Patch for landing 3	none

Brady Eidson

Reported 2016-01-21 13:22:24 PST

Modern IDB: Support populating/extracting database metadata with SQLite backend This patch will also actually enable the SQLite backend in code that is run in layout tests.

Attachments
Patch v1 (97.27 KB, patch) 2016-01-21 15:51 PST, Brady Eidson	achristensen: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Patch for landing (97.00 KB, patch) 2016-01-21 17:14 PST, Brady Eidson	commit-queue: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-yosemite (894.87 KB, application/zip) 2016-01-21 18:29 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (898.59 KB, application/zip) 2016-01-21 18:32 PST, Build Bot	no flags	Details
Patch for landing 2 (97.11 KB, patch) 2016-01-21 20:04 PST, Brady Eidson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (887.43 KB, application/zip) 2016-01-21 20:57 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (811.21 KB, application/zip) 2016-01-21 21:03 PST, Build Bot	no flags	Details
Patch for landing 3 (97.17 KB, patch) 2016-01-21 21:50 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2016-01-21 15:51:54 PST

Created attachment 269508 [details] Patch v1

Brady Eidson

Comment 2 2016-01-21 17:14:24 PST

Created attachment 269524 [details] Patch for landing

WebKit Commit Bot

Comment 3 2016-01-21 18:02:15 PST

Comment on attachment 269524 [details] Patch for landing Rejecting attachment 269524 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ent.dia -c /Volumes/Data/EWS/WebKit/Source/WebCore/dom/StyledElement.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/StyledElement.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/SQLiteIDBBackingStore.o Modules/indexeddb/server/SQLiteIDBBackingStore.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/723422

Build Bot

Comment 4 2016-01-21 18:29:20 PST

Comment on attachment 269508 [details] Patch v1 Attachment 269508 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/723486 New failing tests: fast/history/page-cache-indexed-opened-db.html

Build Bot

Comment 5 2016-01-21 18:29:22 PST

Created attachment 269533 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-01-21 18:32:40 PST

Comment on attachment 269524 [details] Patch for landing Attachment 269524 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/723470 New failing tests: fast/history/page-cache-indexed-opened-db.html

Build Bot

Comment 7 2016-01-21 18:32:42 PST

Created attachment 269535 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Brady Eidson

Comment 8 2016-01-21 19:04:25 PST

Yah, with EWS I can at least explore these! Thank you EWS!

Brady Eidson

Comment 9 2016-01-21 20:04:23 PST

Created attachment 269541 [details] Patch for landing 2 Fixing release build shenanigans with UNUSED_PARAM

Build Bot

Comment 10 2016-01-21 20:57:54 PST

Comment on attachment 269541 [details] Patch for landing 2 Attachment 269541 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/723961 New failing tests: fast/history/page-cache-indexed-opened-db.html

Build Bot

Comment 11 2016-01-21 20:57:57 PST

Created attachment 269544 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 12 2016-01-21 21:03:12 PST

Comment on attachment 269541 [details] Patch for landing 2 Attachment 269541 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/723956 New failing tests: fast/history/page-cache-indexed-opened-db.html

Build Bot

Comment 13 2016-01-21 21:03:14 PST

Created attachment 269545 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

WebKit Commit Bot

Comment 14 2016-01-21 21:14:02 PST

The commit-queue encountered the following flaky tests while processing attachment 269541 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 15 2016-01-21 21:14:05 PST

The commit-queue encountered the following flaky tests while processing attachment 269541 [details]: The commit-queue is continuing to process your patch.

Brady Eidson

Comment 16 2016-01-21 21:50:59 PST

Created attachment 269551 [details] Patch for landing 3

WebKit Commit Bot

Comment 17 2016-01-21 22:40:08 PST

Comment on attachment 269551 [details] Patch for landing 3 Clearing flags on attachment: 269551 Committed r195443: <http://trac.webkit.org/changeset/195443>

Note You need to log in before you can comment on or make changes to this bug.