Bug 153288

Summary: B3 should have load elimination
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 153200    
Bug Blocks: 150507    
Attachments:
Description Flags
work in progress
none
close to done
none
passes all tests
none
the patch
none
the patch
none
the patch ggaren: review+

Description Filip Pizlo 2016-01-20 14:50:10 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-20 14:50:59 PST 
Created attachment 269389 [details]
work in progress
Comment 2 Filip Pizlo 2016-01-21 09:19:34 PST 
Created attachment 269456 [details]
close to done
Comment 3 Filip Pizlo 2016-01-21 10:14:12 PST 
Created attachment 269464 [details]
passes all tests

I don't know if it speeds anything up, yet.
Comment 4 Oliver Hunt 2016-01-21 10:32:03 PST 
(In reply to comment #3)
> Created attachment 269464 [details]
> passes all tests
> 
> I don't know if it speeds anything up, yet.

r=me!!!!!! :D
Comment 5 Filip Pizlo 2016-01-21 10:55:22 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > Created attachment 269464 [details]
> > passes all tests
> > 
> > I don't know if it speeds anything up, yet.
> 
> r=me!!!!!! :D

Booo, no speed-up this time.
Comment 6 Filip Pizlo 2016-01-21 10:55:53 PST 
Created attachment 269470 [details]
the patch
Comment 7 WebKit Commit Bot 2016-01-21 10:57:40 PST 
Attachment 269470 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2016-01-21 11:05:52 PST 
Created attachment 269472 [details]
the patch
Comment 9 WebKit Commit Bot 2016-01-21 11:07:03 PST 
Attachment 269472 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Filip Pizlo 2016-01-21 11:08:40 PST 
Created attachment 269473 [details]
the patch
Comment 11 WebKit Commit Bot 2016-01-21 11:09:59 PST 
Attachment 269473 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Geoffrey Garen 2016-01-21 11:46:01 PST 
Comment on attachment 269473 [details]
the patch

r=me
Comment 13 Filip Pizlo 2016-01-21 11:55:29 PST 
Landed in http://trac.webkit.org/changeset/195417