Bug 153288

Summary: B3 should have load elimination
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 153200    
Bug Blocks: 150507    
Attachments:
Description Flags
work in progress
none
close to done
none
passes all tests
none
the patch
none
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2016-01-20 14:50:10 PST
Patch forthcoming.
Attachments
work in progress (46.50 KB, patch)
2016-01-20 14:50 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
close to done (47.78 KB, patch)
2016-01-21 09:19 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
passes all tests (49.02 KB, patch)
2016-01-21 10:14 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (53.67 KB, patch)
2016-01-21 10:55 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (53.67 KB, patch)
2016-01-21 11:05 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (53.67 KB, patch)
2016-01-21 11:08 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-20 14:50:59 PST
Created attachment 269389 [details] work in progress
Filip Pizlo
Comment 2 2016-01-21 09:19:34 PST
Created attachment 269456 [details] close to done
Filip Pizlo
Comment 3 2016-01-21 10:14:12 PST
Created attachment 269464 [details] passes all tests I don't know if it speeds anything up, yet.
Oliver Hunt
Comment 4 2016-01-21 10:32:03 PST
(In reply to comment #3) > Created attachment 269464 [details] > passes all tests > > I don't know if it speeds anything up, yet. r=me!!!!!! :D
Filip Pizlo
Comment 5 2016-01-21 10:55:22 PST
(In reply to comment #4) > (In reply to comment #3) > > Created attachment 269464 [details] > > passes all tests > > > > I don't know if it speeds anything up, yet. > > r=me!!!!!! :D Booo, no speed-up this time.
Filip Pizlo
Comment 6 2016-01-21 10:55:53 PST
Created attachment 269470 [details] the patch
WebKit Commit Bot
Comment 7 2016-01-21 10:57:40 PST
Attachment 269470 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 8 2016-01-21 11:05:52 PST
Created attachment 269472 [details] the patch
WebKit Commit Bot
Comment 9 2016-01-21 11:07:03 PST
Attachment 269472 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 10 2016-01-21 11:08:40 PST
Created attachment 269473 [details] the patch
WebKit Commit Bot
Comment 11 2016-01-21 11:09:59 PST
Attachment 269473 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 12 2016-01-21 11:46:01 PST
Comment on attachment 269473 [details] the patch r=me
Filip Pizlo
Comment 13 2016-01-21 11:55:29 PST
Landed in http://trac.webkit.org/changeset/195417
Note You need to log in before you can comment on or make changes to this bug.