Bug 153282

Summary:

AX: <code> group and friends should have a custom subrole

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, commit-queue, dmazzoni, jcraig, jdiggs, mario, mcatanzaro, rniwa, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews102 for mac-yosemite	none
Archive of layout-test-results from ews113 for mac-yosemite	none
patch	mario: review+, commit-queue: commit-queue-

Description chris fleizach 2016-01-20 11:47:27 PST

These groups should also have custom subroles and descriptions:
kbd
pre
sample
var
cite
ins
del

<rdar://problem/22550717>

Comment 1 chris fleizach 2016-01-20 11:50:49 PST

Created attachment 269370 [details]
patch

Comment 2 Build Bot 2016-01-20 12:35:41 PST

Comment on attachment 269370 [details]
patch

Attachment 269370 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/718185

New failing tests:
accessibility/duplicate-child-nodes.html
accessibility/roles-computedRoleString.html
accessibility/roles-exposed.html

Comment 3 Build Bot 2016-01-20 12:35:46 PST

Created attachment 269372 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 4 Build Bot 2016-01-20 12:41:38 PST

Comment on attachment 269370 [details]
patch

Attachment 269370 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/718210

New failing tests:
accessibility/duplicate-child-nodes.html
accessibility/roles-computedRoleString.html
accessibility/roles-exposed.html

Comment 5 Build Bot 2016-01-20 12:41:43 PST

Created attachment 269373 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 6 Build Bot 2016-01-20 12:51:39 PST

Comment on attachment 269370 [details]
patch

Attachment 269370 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/718195

New failing tests:
accessibility/duplicate-child-nodes.html
accessibility/roles-computedRoleString.html
accessibility/roles-exposed.html

Comment 7 Build Bot 2016-01-20 12:51:43 PST

Created attachment 269375 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 8 chris fleizach 2016-01-20 12:56:43 PST

Created attachment 269376 [details]
patch

Comment 9 WebKit Commit Bot 2016-01-22 11:25:20 PST

Comment on attachment 269376 [details]
patch

Rejecting attachment 269376 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 269376, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/726329

Comment 10 chris fleizach 2016-01-22 11:32:37 PST

http://trac.webkit.org/changeset/195463

Comment 11 Michael Catanzaro 2016-01-29 20:49:06 PST

This broke two tests, see bug #153696