| Summary: | CSP: Merge from Blink many new tests and changes to existing tests | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||
| Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aestes, ap, bfulgham, buildbot, commit-queue, lforschler, mcatanzaro, mkwst, rniwa, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Bates
2016-01-20 10:13:17 PST
Created attachment 269357 [details]
Layout Tests
Comment on attachment 269357 [details] Layout Tests View in context: https://bugs.webkit.org/attachment.cgi?id=269357&action=review r=me. This is all just a snapshot of a moment in time, so I'm not that concerned with the actual test output -- but please double-check that the missing "sourceFile" values and line/column numbers are expected. > LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:-16 > -PASS window.e.lineNumber is 23 Why are these expected to have no "sourceFIle" or "lineNumber" values? is that what upstream Blink has for its test results? This seems like a regression from existing behavior. (In reply to comment #3) > Comment on attachment 269357 [details] > Layout Tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269357&action=review > > r=me. This is all just a snapshot of a moment in time, so I'm not that > concerned with the actual test output -- but please double-check that the > missing "sourceFile" values and line/column numbers are expected. > > > LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:-16 > > -PASS window.e.lineNumber is 23 > > Why are these expected to have no "sourceFIle" or "lineNumber" values? is > that what upstream Blink has for its test results? Will revert sourceFile and lineNumber changes to the following files before landing: LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html The changes to sourceFile and lineNumber properties of the stack trace in the above files reflect the changes committed to Blink as of the time of writing. These changes are fall out from the patch for issue <https://codereview.chromium.org/200923002> and are recognized as such in its commit message "Unfortunately, this means that some exceptions no longer have a stack trace". > This seems like a regression from existing behavior. You're right! It is a regression from existing behavior. Will revert sourceFile and lineNumber in the aforementioned files. Comment on attachment 269357 [details] Layout Tests Attachment 269357 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/717980 New failing tests: http/tests/security/xssAuditor/report-script-tag-full-block.html Created attachment 269366 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 269357 [details] Layout Tests Attachment 269357 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/717983 New failing tests: http/tests/security/xssAuditor/report-script-tag-full-block.html Created attachment 269367 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 269357 [details] Layout Tests Attachment 269357 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/717971 New failing tests: http/tests/security/xssAuditor/report-script-tag-full-block.html Created attachment 269368 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Committed r195367: <http://trac.webkit.org/changeset/195367> A few of these tests are failing strangely for GTK, see bug #153697. |