Bug 153276

Summary:

[EFL] [GTK] Fails to build dependency gst-plugins-base with system liborc 0.4.24

Product:

WebKit

Reporter:

Julien Isorce <j.isorce>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, obzhirov, ossy, p.jacquemart, pnormand

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Ensure to use compatible liborc version with wanted gstreamer version	none
Ensure to use compatible liborc version with wanted gstreamer version	none
Ensure to use compatible liborc version with wanted gstreamer version	none

Julien Isorce

Reported 2016-01-20 09:27:26 PST

Currently WebKit wants gst 1.4.4 so it should also fetch for liborc 0.4.17. Indeed if user as newer liborc version it will fails to buid at least gstreamer-video-1.0 from gst-plugins-base. Patch follows.

Attachments
Ensure to use compatible liborc version with wanted gstreamer version (2.42 KB, patch) 2016-01-20 09:33 PST, Julien Isorce	no flags	Details Formatted Diff Diff
Ensure to use compatible liborc version with wanted gstreamer version (3.36 KB, patch) 2016-01-21 04:10 PST, Julien Isorce	no flags	Details Formatted Diff Diff
Ensure to use compatible liborc version with wanted gstreamer version (3.51 KB, patch) 2016-01-21 05:17 PST, Julien Isorce	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Julien Isorce

Comment 1 2016-01-20 09:33:25 PST

Created attachment 269354 [details] Ensure to use compatible liborc version with wanted gstreamer version

Philippe Normand

Comment 2 2016-01-20 23:49:42 PST

Ok but a ChangeLog is missing :) You can generate one easily with Tools/Scripts/prepare-ChangeLog -g HEAD

Julien Isorce

Comment 3 2016-01-21 04:10:10 PST

Created attachment 269445 [details] Ensure to use compatible liborc version with wanted gstreamer version

Csaba Osztrogonác

Comment 4 2016-01-21 04:53:32 PST

Comment on attachment 269445 [details] Ensure to use compatible liborc version with wanted gstreamer version View in context: https://bugs.webkit.org/attachment.cgi?id=269445&action=review > Tools/ChangeLog:9 > + Reviewed by NOBODY This line should be unchanged: Reviewed by NOBODY (OOPS!). Because webkit-patch can't fill the reviewer name otherwise.

Julien Isorce

Comment 5 2016-01-21 05:17:54 PST

Created attachment 269449 [details] Ensure to use compatible liborc version with wanted gstreamer version

WebKit Commit Bot

Comment 6 2016-01-21 06:37:22 PST

Comment on attachment 269449 [details] Ensure to use compatible liborc version with wanted gstreamer version Rejecting attachment 269449 [details] from commit-queue. j.isorce@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 7 2016-01-21 07:27:50 PST

Comment on attachment 269449 [details] Ensure to use compatible liborc version with wanted gstreamer version Clearing flags on attachment: 269449 Committed r195408: <http://trac.webkit.org/changeset/195408>

WebKit Commit Bot

Comment 8 2016-01-21 07:27:54 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.