Bug 153268

Summary:

Web Inspector: Subclasses of WebInspector.Object shouldn't overwrite this._listeners

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2016-01-19 21:12:31 PST

Here is a stack trace:

[Error] object._listeners should be a Map but it isn't.
`object` is most likely a WebInspector.EventListenerSet.
	dispatch (Object.js:146)
	dispatchEventToListeners (Object.js:167)
	mainTitle (GeneralTreeElement.js:133)
	_updateTitles (BreakpointTreeElement.js:143)
	BreakpointTreeElement (BreakpointTreeElement.js:57)
	_addBreakpoint (DebuggerSidebarPanel.js:297)
	_addBreakpointsForSourceCode (DebuggerSidebarPanel.js:308)
	_addResource (DebuggerSidebarPanel.js:367)
	_resourceAdded (DebuggerSidebarPanel.js:358)
	dispatch (Object.js:160)
	dispatchEventToListeners (Object.js:175)
	addResource (Frame.js:407)
	_addFrameTreeFromFrameResourceTreePayload (FrameResourceManager.js:563)
	_processMainFrameResourceTreePayload (FrameResourceManager.js:514)
	_processMainFrameResourceTreePayload
	_dispatchResponseToCallback (InspectorBackend.js:297)
	_dispatchResponse (InspectorBackend.js:270)
	dispatch (InspectorBackend.js:149)
	dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42)

Comment 1 Radar WebKit Bug Importer 2016-01-19 21:12:57 PST

<rdar://problem/24252766>

Comment 2 Nikita Vasilyev 2016-01-19 21:21:22 PST

Created attachment 269333 [details]
Patch

Comment 3 WebKit Commit Bot 2016-01-19 22:21:11 PST

Comment on attachment 269333 [details]
Patch

Clearing flags on attachment: 269333

Committed r195343: <http://trac.webkit.org/changeset/195343>

Comment 4 WebKit Commit Bot 2016-01-19 22:21:15 PST

All reviewed patches have been landed.  Closing bug.