Bug 153250 – LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html crashing

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html crashing

Recent crashing runs:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2301>
<https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20WK2%20(Tests)/builds/9453>

Flakiness dashboard:
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FxssAuditor%2Fembed-tag-in-path-unterminated.html>

[Radar WebKit Bug Importer]

<rdar://problem/24248040>

[Daniel Bates]

Using a debug build of WebKit, run:

Tools/Scripts/run-webkit-tests --debug --no-retry-failures --child-processes=1 http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html

Then we will crash because the assertion ASSERT(directoryURL.length() == directoryURLPathStart + 1 || directoryURL[directoryURL.length() - 1] != '/') fails in CredentialStorage::findDefaultProtectionSpaceForURL().

[Daniel Bates]

*** Bug 153372 has been marked as a duplicate of this bug. ***

[Daniel Bates]

Created attachment 269608 [details]
Patch an layout tests

[Build Bot]

Comment on attachment 269608 [details]
Patch an layout tests

Attachment 269608 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/726969

New failing tests:
http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html

[Build Bot]

Created attachment 269618 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 269608 [details]
Patch an layout tests

Attachment 269608 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/726982

New failing tests:
http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html

[Build Bot]

Created attachment 269620 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Daniel Bates]

Committed r195493: <http://trac.webkit.org/changeset/195493>

[Alexey Proskuryakov]

This broke tests (EWS told us so):

https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r195493%20(11355)/results.html

Will roll out.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 153397

[Daniel Bates]

(In reply to comment #10)
> This broke tests (EWS told us so):

Where do you see that the EWS foresaw the failures seen in <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r195493%20(11355)/results.html>?

In <https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r195493%20(11355)/results.html> the tests that failed due to text/pixel/audio differences were http/tests/loading/basic-auth-resend-wrong-credentials.html and http/tests/loading/basic-credentials-sent-automatically.html.

[Daniel Bates]

(In reply to comment #10)
> This broke tests [...]

To clarify, <http://trac.webkit.org/changeset/195493> broke tests because WebKitTestRunner does not clear cached credentials between runs (bug #153407). The committed test LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html and LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html authenticate to a protected resource in the same protection space, <http://127.0.0.1:8000/resources>.

[Daniel Bates]

(In reply to comment #13)
> (In reply to comment #10)
> > This broke tests [...]
> 
> To clarify, <http://trac.webkit.org/changeset/195493> broke tests because
> WebKitTestRunner does not clear cached credentials between runs (bug
> #153407). The committed test
> LayoutTests/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.
> html and
> LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html
> authenticate to a protected resource in the same protection space,
> <http://127.0.0.1:8000/resources>.

I meant to add:

Obviously, removing the assert did not cause the test failures.

[Alexey Proskuryakov]

> Where do you see that the EWS foresaw the failures seen in 

It didn't catch all the same failures - because tests can be split differently in each run - but it did detect regressions.

> <http://trac.webkit.org/changeset/195493> broke tests because WebKitTestRunner does not clear cached credentials between runs

This is one way to put it, however the immediate cause for the problem was that the test is not in a subdirectory, unlike all other authentication tests. The fix can be re-landed after moving the new test to a subdirectory.

[Daniel Bates]

(In reply to comment #15)
> [...]
> The fix can be re-landed after moving the new test to a subdirectory.

Following the fix for bug #153407, we no longer need to make a new directory to contain the protected resource for each authentication test to avoid the issue of cached credentials. Unless you feel strongly about creating a new directory, I plan to re-land the patch as-is.

[Daniel Bates]

Committed r195590: <http://trac.webkit.org/changeset/195590>

[Michael Catanzaro]

It broke a couple auth layout tests on GTK, see bug #158919.