Bug 153218

Summary: Make it possible to turn on VIDEO_PRESENTATION_MODE on cocoa platforms
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: adachan, commit-queue, eric.carlson, jer.noble
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Take 2. This time using diff instead of git format-patch.
none
Patch
none
Patch eric.carlson: review+

Ada Chan
Reported 2016-01-18 22:10:54 PST
Make it possible to turn on VIDEO_PRESENTATION_MODE on cocoa platforms. <rdar://problem/24171264>
Attachments
Patch (44.02 KB, patch)
2016-01-19 14:26 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Take 2. This time using diff instead of git format-patch. (35.99 KB, patch)
2016-01-19 15:10 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (29.90 KB, patch)
2016-01-20 13:16 PST, Ada Chan 		no flags
DetailsFormatted DiffDiff
Patch (29.88 KB, patch)
2016-01-20 13:29 PST, Ada Chan 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2016-01-19 14:26:22 PST
Created attachment 269296 [details] Patch
Ada Chan
Comment 2 2016-01-19 15:10:05 PST
Created attachment 269301 [details] Take 2. This time using diff instead of git format-patch. Not sure what's wrong exactly last time. Trying again using plain diff instead of git format-patch.
Ada Chan
Comment 3 2016-01-20 00:52:30 PST
Comment on attachment 269301 [details] Take 2. This time using diff instead of git format-patch. I'll post an updated patch tomorrow.
Ada Chan
Comment 4 2016-01-20 13:16:20 PST
Created attachment 269379 [details] Patch
WebKit Commit Bot
Comment 5 2016-01-20 13:19:11 PST
Attachment 269379 [details] did not pass style-queue: ERROR: Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h:53: The parameter name "bufferedTime" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ada Chan
Comment 6 2016-01-20 13:29:47 PST
Created attachment 269380 [details] Patch
Eric Carlson
Comment 7 2016-01-21 06:57:44 PST
Comment on attachment 269380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269380&action=review > Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h:2 > + * Copyright (C) 2014 Apple Inc. All rights reserved. Nit: probably worth updating this date. > Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h:26 > + > + Nit: two blank lines aren't necessary.
Ada Chan
Comment 8 2016-01-21 10:24:11 PST
(In reply to comment #7) > Comment on attachment 269380 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269380&action=review > > > Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h:2 > > + * Copyright (C) 2014 Apple Inc. All rights reserved. Changed to 2014-2016 > > Nit: probably worth updating this date. > > > Source/WebCore/platform/cocoa/WebVideoFullscreenInterface.h:26 > > + > > + > > Nit: two blank lines aren't necessary. Removed one blank line. Thanks for the review!
Ada Chan
Comment 9 2016-01-21 10:26:19 PST
Committed: http://trac.webkit.org/changeset/195412
Note You need to log in before you can comment on or make changes to this bug.