Summary: | [CMake] FindLLVM.cmake does not find shared library on OSX, Windows, or with llvm 3.8+ | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | CLOSED FIXED | ||
Severity: | Normal | CC: | cgarcia, mcatanzaro |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=151559 | ||
Bug Depends on: | |||
Bug Blocks: | 126492 |
Description
Jeremy Huddleston Sequoia
2016-01-16 21:36:19 PST
I guess it depends on the distro in the case of Linux, in debian it's /usr/lib/x86_64-linux-gnu/libLLVM-3.8.0.so.1 Or maybe it has to do with the build system. llvm deprecated autoconf in favor of cmake in llvm-3.8, so maybe it's that their cmake build system is not appending the version number but the deprecated autoconf-based build system still is. In the openSUSE changelog for WebKit I see: " + Inject a llvm-config wrapper script into ~/bin, which replaces the original's output of static libs with dynamic shared objects. This is supposedly going to be corrected with LLVM 3.8." https://build.opensuse.org/package/view_file/GNOME:Next/webkit2gtk3/webkit2gtk3.changes Jeremy, do you know if there is some less-hacky way to get shared libraries out of llvm-config in LLVM 3.8, as implied by that changelog? If so, we should switch to using that... otherwise we will just have to add whatever hacks necessary to FindLLVM.cmake to make it work. You could also build with -DENABLE_FTL_JIT=OFF to avoid the dependency on LLVM, but this doesn't look too hard to solve.... (And does anyone know why LLVM thinks it's remotely acceptable to not ship a pkg-config file?) |