Bug 153163

Summary:

[MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adam.bergkvist, buildbot, commit-queue, jonlee, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP patch for the bots to chew on	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Another WIP patch for the bots to check.	buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Patch for the bots.	none
Updated patch for the bots.	none
Another updated patch for the bots.	none
Another updated patch.	none
Another updated patch.	none
Another updated patch.	none
Another updated patch.	none
Another updated patch.	none
Proposed patch.	none

Eric Carlson

Reported 2016-01-15 15:50:57 PST

MediaDeviceInfo.deviceId and MediaDeviceInfo.groupId must be unique to the page origin, but they must be stable across browsing sessions if the user has granted persistent permission to an origin to access local devices. When in Private Browsing, different identifiers must be used that do not persist across sessions. Persistent identifiers must be reset when the user clears cached identifiers (eg. cookies).

Attachments
WIP patch for the bots to chew on (111.41 KB, patch) 2016-01-15 16:27 PST, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (933.85 KB, application/zip) 2016-01-15 17:41 PST, Build Bot	no flags	Details
Another WIP patch for the bots to check. (109.91 KB, patch) 2016-01-20 09:31 PST, Eric Carlson	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (941.52 KB, application/zip) 2016-01-20 10:31 PST, Build Bot	no flags	Details
Patch for the bots. (100.40 KB, patch) 2016-02-23 16:32 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Updated patch for the bots. (100.45 KB, patch) 2016-02-23 17:56 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch for the bots. (101.04 KB, patch) 2016-02-24 09:59 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (104.61 KB, patch) 2016-02-24 10:58 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (105.33 KB, patch) 2016-02-24 11:18 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (105.91 KB, patch) 2016-02-24 11:42 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (106.10 KB, patch) 2016-02-24 11:56 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Another updated patch. (105.49 KB, patch) 2016-02-24 12:12 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Proposed patch. (104.72 KB, patch) 2016-02-24 12:58 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2016-01-15 16:27:03 PST

Created attachment 269119 [details] WIP patch for the bots to chew on

WebKit Commit Bot

Comment 2 2016-01-15 16:29:36 PST

Attachment 269119 [details] did not pass style-queue: ERROR: Source/WebCore/CMakeLists.txt:924: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WebCore/CMakeLists.txt:924: Alphabetical sorting problem. "Modules/mediastream/MediaDeviceIdentifierHashSaltRequest.cpp" should be before "Modules/mediastream/MediaDevices.cpp". [list/order] [5] Total errors found: 2 in 67 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2016-01-15 17:41:08 PST

Comment on attachment 269119 [details] WIP patch for the bots to chew on Attachment 269119 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/696324 New failing tests: http/tests/media/media-stream/enumerate-devices-source-id.html http/tests/media/media-stream/enumerate-devices-source-id-frame.html http/tests/contentextensions/font-display-none-repeated-layout.html http/tests/media/media-stream/enumerate-devices-source-id-persistent-permission-frame.html

Build Bot

Comment 4 2016-01-15 17:41:10 PST

Created attachment 269134 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Eric Carlson

Comment 5 2016-01-20 09:31:06 PST

Created attachment 269353 [details] Another WIP patch for the bots to check.

Build Bot

Comment 6 2016-01-20 10:31:31 PST

Comment on attachment 269353 [details] Another WIP patch for the bots to check. Attachment 269353 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/717781 New failing tests: http/tests/media/media-stream/enumerate-devices-source-id.html

Build Bot

Comment 7 2016-01-20 10:31:36 PST

Created attachment 269356 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Radar WebKit Bug Importer

Comment 8 2016-01-25 14:37:21 PST

<rdar://problem/24334526>

Eric Carlson

Comment 9 2016-02-23 16:32:26 PST

Created attachment 272062 [details] Patch for the bots.

Eric Carlson

Comment 10 2016-02-23 17:56:54 PST

Created attachment 272073 [details] Updated patch for the bots.

Eric Carlson

Comment 11 2016-02-24 09:59:38 PST

Created attachment 272116 [details] Another updated patch for the bots.

Eric Carlson

Comment 12 2016-02-24 10:58:13 PST

Created attachment 272120 [details] Another updated patch.

Eric Carlson

Comment 13 2016-02-24 11:18:31 PST

Created attachment 272124 [details] Another updated patch.

Eric Carlson

Comment 14 2016-02-24 11:42:47 PST

Created attachment 272130 [details] Another updated patch.

Eric Carlson

Comment 15 2016-02-24 11:56:30 PST

Created attachment 272133 [details] Another updated patch.

Eric Carlson

Comment 16 2016-02-24 12:12:47 PST

Created attachment 272134 [details] Another updated patch.

Eric Carlson

Comment 17 2016-02-24 12:58:06 PST

Created attachment 272141 [details] Proposed patch.

Tim Horton

Comment 18 2016-02-24 13:19:48 PST

Comment on attachment 272141 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=272141&action=review > Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp:99 > +static void hashString(SHA1& sha1, const String& string) Surprising this is here and not elsewhere. Very nitpicky string logic to be in media code.

Eric Carlson

Comment 19 2016-02-25 07:18:14 PST

Committed r197114: <http://trac.webkit.org/changeset/197114>

Eric Carlson

Comment 20 2016-02-25 08:35:50 PST

And https://trac.webkit.org/r197120 to fix the iOS builds.

Note You need to log in before you can comment on or make changes to this bug.