| Summary: | [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | adam.bergkvist, buildbot, commit-queue, jonlee, rniwa, webkit-bug-importer | ||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||
|
Description
Eric Carlson
2016-01-15 15:50:57 PST
Created attachment 269119 [details]
WIP patch for the bots to chew on
Attachment 269119 [details] did not pass style-queue:
ERROR: Source/WebCore/CMakeLists.txt:924: No trailing spaces [whitespace/trailing] [5]
ERROR: Source/WebCore/CMakeLists.txt:924: Alphabetical sorting problem. "Modules/mediastream/MediaDeviceIdentifierHashSaltRequest.cpp" should be before "Modules/mediastream/MediaDevices.cpp". [list/order] [5]
Total errors found: 2 in 67 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 269119 [details] WIP patch for the bots to chew on Attachment 269119 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/696324 New failing tests: http/tests/media/media-stream/enumerate-devices-source-id.html http/tests/media/media-stream/enumerate-devices-source-id-frame.html http/tests/contentextensions/font-display-none-repeated-layout.html http/tests/media/media-stream/enumerate-devices-source-id-persistent-permission-frame.html Created attachment 269134 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 269353 [details]
Another WIP patch for the bots to check.
Comment on attachment 269353 [details] Another WIP patch for the bots to check. Attachment 269353 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/717781 New failing tests: http/tests/media/media-stream/enumerate-devices-source-id.html Created attachment 269356 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 272062 [details]
Patch for the bots.
Created attachment 272073 [details]
Updated patch for the bots.
Created attachment 272116 [details]
Another updated patch for the bots.
Created attachment 272120 [details]
Another updated patch.
Created attachment 272124 [details]
Another updated patch.
Created attachment 272130 [details]
Another updated patch.
Created attachment 272133 [details]
Another updated patch.
Created attachment 272134 [details]
Another updated patch.
Created attachment 272141 [details]
Proposed patch.
Comment on attachment 272141 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=272141&action=review > Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp:99 > +static void hashString(SHA1& sha1, const String& string) Surprising this is here and not elsewhere. Very nitpicky string logic to be in media code. Committed r197114: <http://trac.webkit.org/changeset/197114> And https://trac.webkit.org/r197120 to fix the iOS builds. |