Bug 153147

Summary: Drop obsolete DocumentType.entities / notations
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, kangil.han, kling, koivisto, kondapallykalyan, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-01-15 14:24:18 PST
Drop obsolete DocumentType.entities / notations. Firefox and Chrome already dropped those. We already dropped support for entities and notations so these always return null.
Attachments
Patch (4.57 KB, patch)
2016-01-15 14:30 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-01-15 14:30:35 PST
Created attachment 269100 [details] Patch
WebKit Commit Bot
Comment 2 2016-01-15 16:08:57 PST
Comment on attachment 269100 [details] Patch Clearing flags on attachment: 269100 Committed r195157: <http://trac.webkit.org/changeset/195157>
WebKit Commit Bot
Comment 3 2016-01-15 16:09:02 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2016-01-18 14:43:55 PST
Comment on attachment 269100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269100&action=review > Source/WebCore/dom/DocumentType.h:40 > + // These is needed by native bindings for backward compatibility. “These is needed” -> “These are needed”. I’m not sure that “native bindings” is a clear name for the Objective-C and GTK bindings.
Chris Dumez
Comment 5 2016-01-19 09:50:40 PST
(In reply to comment #4) > Comment on attachment 269100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269100&action=review > > > Source/WebCore/dom/DocumentType.h:40 > > + // These is needed by native bindings for backward compatibility. > > “These is needed” -> “These are needed”. > > I’m not sure that “native bindings” is a clear name for the Objective-C and > GTK bindings. Updated comment in <http://trac.webkit.org/changeset/195294>.
Note You need to log in before you can comment on or make changes to this bug.