Bug 153119

Summary: createElementNS and createAttributeNS should treat undefined namespaceURI as null string
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kling, koivisto, kondapallykalyan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug cdumez: review+, cdumez: commit-queue-

Ryosuke Niwa
Reported 2016-01-15 00:21:57 PST
Related to webkit.org/b/149238. We should treat undefined as nulls in createElementNS and createAttributeNS.
Attachments
Fixes the bug (9.28 KB, patch)
2016-01-15 00:24 PST, Ryosuke Niwa 		cdumez: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-01-15 00:24:10 PST
Created attachment 269041 [details] Fixes the bug
Chris Dumez
Comment 2 2016-01-15 09:05:53 PST
Comment on attachment 269041 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=269041&action=review r=me with comments. > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace-expected.txt:3 > +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". There is no TEST COMPLETE at the end :P > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace.html:10 > +shouldBe('attr.prefix', 'null'); shouldBeNull() > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace.html:11 > +shouldBe('attr.localName', '"foo"'); shouldBeEqualToString() > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace.html:12 > +shouldBe('attr.namespaceURI', 'null'); shouldBeNull() > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace.html:13 > +shouldBe('element.getAttributeNodeNS(null, "foo")', 'null'); shouldBeNull() > LayoutTests/fast/dom/Document/createAttributeNS-undefined-namespace.html:16 > +</script> You're missing the -post script.
Ryosuke Niwa
Comment 3 2016-01-15 15:06:43 PST
Committed r195152: <http://trac.webkit.org/changeset/195152>
Note You need to log in before you can comment on or make changes to this bug.