Bug 153106

Summary: [webkitdirs] Replaced grep invocation with perl code
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dbates, lforschler, ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-01-14 13:50:51 PST
As proposed in https://bugs.webkit.org/show_bug.cgi?id=152959#c9 Also, removed outdated comment.
Attachments
Patch (1.76 KB, patch)
2016-01-14 13:51 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (1.29 KB, patch)
2016-01-15 07:30 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-01-14 13:51:59 PST
Created attachment 269000 [details] Patch
WebKit Commit Bot
Comment 2 2016-01-14 16:50:29 PST
Comment on attachment 269000 [details] Patch Clearing flags on attachment: 269000 Committed r195083: <http://trac.webkit.org/changeset/195083>
WebKit Commit Bot
Comment 3 2016-01-14 16:50:32 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2016-01-15 06:06:28 PST
(In reply to comment #2) > Comment on attachment 269000 [details] > Patch > > Clearing flags on attachment: 269000 > > Committed r195083: <http://trac.webkit.org/changeset/195083> It broke the WinCairo build: List form of pipe open not implemented at C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Tools/Scripts/webkitdirs.pm line 342. Compilation failed in require at ./Tools/Scripts/build-webkit line 44. BEGIN failed--compilation aborted at ./Tools/Scripts/build-webkit line 44.
Konstantin Tokarev
Comment 5 2016-01-15 06:23:55 PST
I guess different Perl versions are used in WinCairo and Win builders. However, this is very easy to fix, I just wasn't aware that list form of open has portability issues
Konstantin Tokarev
Comment 6 2016-01-15 07:30:53 PST
Reopening to attach new patch.
Konstantin Tokarev
Comment 7 2016-01-15 07:30:57 PST
Created attachment 269050 [details] Patch
WebKit Commit Bot
Comment 8 2016-01-15 19:57:40 PST
Comment on attachment 269050 [details] Patch Clearing flags on attachment: 269050 Committed r195163: <http://trac.webkit.org/changeset/195163>
WebKit Commit Bot
Comment 9 2016-01-15 19:57:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.