Bug 152947

Summary: [mips] Implemented emitFunctionPrologue/Epilogue
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbriance, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-01-09 11:26:13 PST
Implemented AssemblyHelpers::emitFunctionPrologue and AssemblyHelpers::emitFunctionEpilogue for MIPS.
Attachments
Patch (1.59 KB, patch)
2016-01-09 11:27 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2016-01-15 06:18 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-01-09 11:27:57 PST
Created attachment 268625 [details] Patch
Julien Brianceau
Comment 2 2016-01-15 05:10:43 PST
LGTM
Konstantin Tokarev
Comment 3 2016-01-15 06:18:23 PST
Created attachment 269046 [details] Patch
Konstantin Tokarev
Comment 4 2016-01-15 06:26:02 PST
New version of patch introduces ARM-style pushPair/popPair helpers to reduce number of stack pointer changes.
Julien Brianceau
Comment 5 2016-01-15 08:07:43 PST
Even better, LGTM
Michael Saboff
Comment 6 2016-01-15 10:07:33 PST
Comment on attachment 269046 [details] Patch r=me
WebKit Commit Bot
Comment 7 2016-01-15 10:53:53 PST
Comment on attachment 269046 [details] Patch Clearing flags on attachment: 269046 Committed r195134: <http://trac.webkit.org/changeset/195134>
WebKit Commit Bot
Comment 8 2016-01-15 10:53:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.