Bug 152941

Summary: Web Inspector: Test Resources should not be included in Production builds unless FORCE_TOOL_INSTALL
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, mitz, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-01-08 21:33:02 PST
* SUMMARY Test Resources should not be included in Production builds unless FORCE_TOOL_INSTALL. The following test resources are unexpectedly found in Production builds: ./System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/TestEsprima.js ./System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/Test.html ./System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/TestCombined.js
Attachments
[PATCH] Proposed Fix (7.37 KB, patch)
2016-01-08 21:39 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-08 21:33:16 PST
<rdar://problem/24119013>
Joseph Pecoraro
Comment 2 2016-01-08 21:39:20 PST
Created attachment 268613 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2016-01-08 22:32:39 PST
Comment on attachment 268613 [details] [PATCH] Proposed Fix Clearing flags on attachment: 268613 Committed r194818: <http://trac.webkit.org/changeset/194818>
WebKit Commit Bot
Comment 4 2016-01-08 22:32:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.