Bug 152925

Summary: B3 needs Neg()
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 150279    
Attachments:
Description Flags
work in progress
none
the patch mark.lam: review+

Filip Pizlo
Reported 2016-01-08 13:49:18 PST
Currently B3 expresses -x as 0-x. That's wrong in case of floating point. It's probably better if we just have a Neg opcode, and this opcode should work for both ints and floats.
Attachments
work in progress (12.74 KB, patch)
2016-01-08 14:12 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (15.79 KB, patch)
2016-01-08 15:35 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-01-08 14:12:29 PST
Created attachment 268584 [details] work in progress
Filip Pizlo
Comment 2 2016-01-08 15:35:42 PST
Created attachment 268595 [details] the patch
Mark Lam
Comment 3 2016-01-08 16:00:01 PST
Comment on attachment 268595 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268595&action=review r=me > Source/JavaScriptCore/ChangeLog:18 > + So, this introduces a proper Neg() opcode to B3. It's not the canonical way of saying typo: "not" ==> "now".
Filip Pizlo
Comment 4 2016-01-08 16:03:59 PST
Landed in http://trac.webkit.org/changeset/194802
Note You need to log in before you can comment on or make changes to this bug.