Bug 152921

Summary: Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 150882, 152554    
Attachments:
Description Flags
Patch v1
achristensen: review+, buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews117 for mac-yosemite none

Brady Eidson
Reported 2016-01-08 13:06:59 PST
Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set get and set do an unnecessary utf8().data() call on the string they are passing, resulting in buggy property lookups or injections. get() was covered by an existing failing test. set() will be covered by a change to an existing test.
Attachments
Patch v1 (8.36 KB, patch)
2016-01-08 13:14 PST, Brady Eidson 		achristensen: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (818.46 KB, application/zip)
2016-01-08 13:44 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (786.98 KB, application/zip)
2016-01-08 14:06 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-yosemite (806.26 KB, application/zip)
2016-01-08 14:09 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-08 13:14:33 PST
Created attachment 268575 [details] Patch v1
Build Bot
Comment 2 2016-01-08 13:44:42 PST
Comment on attachment 268575 [details] Patch v1 Attachment 268575 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/668253 New failing tests: imported/w3c/indexeddb/keypath.htm
Build Bot
Comment 3 2016-01-08 13:44:44 PST
Created attachment 268579 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-01-08 14:06:12 PST
Comment on attachment 268575 [details] Patch v1 Attachment 268575 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/668295 New failing tests: imported/w3c/indexeddb/keypath.htm
Build Bot
Comment 5 2016-01-08 14:06:15 PST
Created attachment 268582 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-01-08 14:09:52 PST
Comment on attachment 268575 [details] Patch v1 Attachment 268575 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/668291 New failing tests: imported/w3c/indexeddb/keypath.htm
Build Bot
Comment 7 2016-01-08 14:09:56 PST
Created attachment 268583 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Brady Eidson
Comment 8 2016-01-08 14:18:55 PST
Yup, I forgot to include the updated results in the patch. My bad! They're there.
Brady Eidson
Comment 9 2016-01-08 14:21:58 PST
https://trac.webkit.org/changeset/194789
Note You need to log in before you can comment on or make changes to this bug.