Bug 152920

Summary: CSS3 columns - invisible elements in non-first column
Product: WebKit Reporter: Simmo Saan <simmo.saan>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan, simon.fraser, webkit-bug-importer, webkit
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
URL: https://sim642.github.io/FLL-scorer/
Attachments:
Description Flags
Screenshot of the page in question
none
Patch simon.fraser: review+

Description Simmo Saan 2016-01-08 13:04:40 PST
I have a bootstrap page in which I make use of CSS3 columns: https://sim642.github.io/FLL-scorer/. These panels contain bootstrap radio button groups.

When viewing this page on a wide enough screen to cause it to activate the multi-column layout, the button groups turn invisible but still exist in inspector. When forcing a single column layout they show up as intended. On iOS Safari I noticed them being broken a bit differently: some of the panel content would show up fully, some would be invisible, even the text.

The problem is that elements seem to randomly turn invisible in columns which are not the first.
Comment 1 Simmo Saan 2016-01-08 13:09:37 PST
Created attachment 268574 [details]
Screenshot of the page in question
Comment 2 Radar WebKit Bug Importer 2016-01-08 13:09:56 PST
<rdar://problem/24111946>
Comment 3 Dave Hyatt 2016-01-21 10:47:14 PST
Created attachment 269468 [details]
Patch
Comment 4 Dean Jackson 2016-01-21 10:52:00 PST
Comment on attachment 269468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269468&action=review

> Source/WebCore/ChangeLog:19
> +        Make sure the crawl up the containing block chain to apply clips properly offsets
> +        to account for columns. convertToLayerCoords could already handle this, so
> +        offsetFromAncestor now takes the same extra argument (whether or not to adjust for
> +        columns) that convertToLayerCoords does.

This bit usually goes before the list of files.

> LayoutTests/fast/multicol/border-radius-overflow-columns.html:12
> +            -webkit-columns: 2;

Don't need this any more.
Comment 5 Dave Hyatt 2016-01-22 09:36:16 PST
Fixed in r195453.
Comment 6 Simon Fraser (smfr) 2016-03-23 18:56:59 PDT
*** Bug 155823 has been marked as a duplicate of this bug. ***