Bug 152915

Summary: Nullopt and InPlace should be structs, not enum values
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Anders Carlsson 2016-01-08 11:48:57 PST 
Nullopt and InPlace should be structs, not enum values
Comment 1 Anders Carlsson 2016-01-08 11:57:23 PST 
Created attachment 268566 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-08 11:59:07 PST 
Attachment 268566 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/StdLibExtras.h:362:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2016-01-08 13:10:12 PST 
Comment on attachment 268566 [details]
Patch

igp;r=me
Comment 4 Anders Carlsson 2016-01-08 13:33:08 PST 
Committed r194784: <http://trac.webkit.org/changeset/194784>