Bug 152906 – Hovering link on http://help.apple.com/appletv/#/ does not show text underline.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

1. Open http://help.apple.com/appletv/#/
2. Resize browser to be wide (bug does not reproduce when narrow)
3. Hover the trademark link
  => no underline on 2nd line of text

[alan]

rdar://problem/23339617

[alan]

Created attachment 268558 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 268558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268558&action=review

> Source/WebCore/ChangeLog:10
> +        This additional visual overflow offset is not taken into account at visualOverflowForDecorations().

s/at/by/

[alan]

Committed r194775: <http://trac.webkit.org/changeset/194775>

[Joseph Pecoraro]

Comment on attachment 268558 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268558&action=review

> LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html:35
> +        shouldNotBe("window.internals.repaintRectsAsText().indexOf('8 8 784 13')", "-1");
> +        shouldNotBe("window.internals.repaintRectsAsText().indexOf('8 20 784 13')", "-1");

String.prototype.includes is a tad nicer than String.prototype.indexOf !== -1. These could be:
shouldBeTrue(window.internals.repaintRectsAsText().includes('8 8 784 13'));