Bug 15289

Summary: WebKit does not respect clip paths of a 0x0 rect
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
simple test case
none
First attempt mitz: review+

Eric Seidel (no email)
Reported 2007-09-26 14:11:27 PDT
WebKit does not respect clip paths of a 0x0 rect I'm not certain what the proper behavior here is. Likely given a 0x0 rect as the clip path the clip should be completely empty (that's what firefox seems to do, and that's what the test I created expects).
Attachments
simple test case (283 bytes, image/svg+xml)
2007-09-26 14:12 PDT, Eric Seidel (no email) 		no flags
Details
First attempt (291.78 KB, patch)
2007-12-05 13:17 PST, Rob Buis 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2007-09-26 14:12:08 PDT
Created attachment 16402 [details] simple test case
Rob Buis
Comment 2 2007-12-05 13:17:08 PST
Created attachment 17724 [details] First attempt This patch implements the clipping of empty clip paths just like FF and Opera do it. The changed test results are because text clipping does not work yet (I assume), as text probably doesnt do toPathData yet, so the behaviour is the same as just having an empty clip path. Cheers, Rob.
mitz
Comment 3 2007-12-05 13:34:33 PST
Comment on attachment 17724 [details] First attempt + pathData.addRect(FloatRect( 0, 0, 0, 0 )); I think just FloatRect() should work. Make sure it also does the right thing for for a 0 x n rect. r=me
Rob Buis
Comment 4 2007-12-05 23:42:00 PST
Landed in r28483.
Note You need to log in before you can comment on or make changes to this bug.