Bug 152889

Summary: [JSC] Make branchMul functional in ARM B3 and minor fixes
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2016-01-08 06:16:30 PST
[JSC] Make branchMul functional in ARM B3 and minor fixes
Attachments
Patch (11.60 KB, patch)
2016-01-08 06:31 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.82 KB, patch)
2016-01-10 13:32 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-01-08 06:31:12 PST
Created attachment 268542 [details] Patch
Mark Lam
Comment 2 2016-01-08 08:27:43 PST
Comment on attachment 268542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268542&action=review r=me > Source/JavaScriptCore/b3/B3LowerToAir.cpp:2102 > } Does it make sense to have an else clause here with a RELEASE_ASSERT_NOT_REACHED? Or are we guaranteed that we'll never get anything but the above forms? > Source/JavaScriptCore/b3/air/AirOpcode.opcodes:582 > +arm64: BranchMul32 U:G:32, U:G:32, U:G:32, S:G:32, S:G:32, ZD:G:32 /branch > + ResCond, Tmp, Tmp, Tmp, Tmp, Tmp Please add a comment at the top of AirOpcode.opcodes for the meaning of S:G:32 to point out that S means Scratch.
Benjamin Poulain
Comment 3 2016-01-10 13:32:17 PST
Created attachment 268662 [details] Patch for landing
WebKit Commit Bot
Comment 4 2016-01-10 14:33:16 PST
Comment on attachment 268662 [details] Patch for landing Clearing flags on attachment: 268662 Committed r194833: <http://trac.webkit.org/changeset/194833>
WebKit Commit Bot
Comment 5 2016-01-10 14:33:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.