Bug 152887

Summary:

[B3] Fix control reaches end of non-void function GCC warnings on Linux

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, benjamin, commit-queue, darin, fpizlo, ggaren, keith_miller, mark.lam, msaboff, ossy, saam

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

152248

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2016-01-08 05:30:26 PST

One example:
../../Source/JavaScriptCore/b3/B3Type.h: In function 'size_t JSC::B3::sizeofType(JSC::B3::Type)':
../../Source/JavaScriptCore/b3/B3Type.h:71:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors

See the following bug reports for details:
- bug150794
- bug150842

There are many places where this warning hit in B3. It is clear that it isn't a 
false warning, we should assert to avoid undefined behaviour. At least in debug
not to make the compiler to emit extra codes in hot paths.

Comment 1 Csaba Osztrogonác 2016-01-08 06:25:56 PST

Created attachment 268540 [details]
Patch

Comment 2 Mark Lam 2016-01-08 08:32:37 PST

Comment on attachment 268540 [details]
Patch

r=me

Comment 3 WebKit Commit Bot 2016-01-11 10:13:52 PST

Comment on attachment 268540 [details]
Patch

Clearing flags on attachment: 268540

Committed r194858: <http://trac.webkit.org/changeset/194858>

Comment 4 WebKit Commit Bot 2016-01-11 10:13:56 PST

All reviewed patches have been landed.  Closing bug.