Bug 152884

Summary: [mips] Max value of immediate arg of logical ops is 0xffff
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbriance, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-01-08 03:37:49 PST
Replaced imm.m_value < 65535 checks with imm.m_value <= 65535
Attachments
Patch (2.38 KB, patch)
2016-01-08 03:39 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (2.45 KB, patch)
2016-01-08 03:50 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-01-08 03:39:48 PST
Created attachment 268534 [details] Patch
Konstantin Tokarev
Comment 2 2016-01-08 03:50:27 PST
Created attachment 268536 [details] Patch
Julien Brianceau
Comment 3 2016-01-08 04:29:49 PST
LGTM
Michael Saboff
Comment 4 2016-01-08 07:48:49 PST
Comment on attachment 268536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268536&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:292 > - else if (imm.m_value > 0 && imm.m_value < 65535 && !m_fixedWidth) > + else if (imm.m_value > 0 && imm.m_value <= 65535 && !m_fixedWidth) This is fine, but you could also write: else if ((imm.m_value & 0xffff) == imm.m_value) && !m_fixedWidth)
WebKit Commit Bot
Comment 5 2016-01-08 08:37:53 PST
Comment on attachment 268536 [details] Patch Clearing flags on attachment: 268536 Committed r194764: <http://trac.webkit.org/changeset/194764>
WebKit Commit Bot
Comment 6 2016-01-08 08:37:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.