Bug 152813

Summary: Perf dashboard should auto-generate manifest file when one is missing
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dewei_zhu, jond, kling, koivisto, rniwa, slewis, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug cdumez: review+, cdumez: commit-queue+

Ryosuke Niwa
Reported 2016-01-06 16:25:14 PST
It's super annoying that one has to remember to open /admin/regenerate-manifest.php when cloning a database. The front-end code should do this automatically.
Attachments
Fixes the bug (6.07 KB, patch)
2016-01-06 16:27 PST, Ryosuke Niwa 		cdumez: review+
cdumez: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2016-01-06 16:27:57 PST
Created attachment 268421 [details] Fixes the bug
Chris Dumez
Comment 2 2016-01-06 16:56:13 PST
Comment on attachment 268421 [details] Fixes the bug r=me
Ryosuke Niwa
Comment 3 2016-01-06 16:57:23 PST
Committed r194679: <http://trac.webkit.org/changeset/194679>
Ryosuke Niwa
Comment 4 2016-01-06 16:57:55 PST
Comment on attachment 268421 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=268421&action=review > Websites/perf.webkit.org/public/api/manifest.php:18 > + exit_with_success($generator->manifest()); Apparently I forgot to include the change to add Manifest::manifest. Landed the patch with that.
Note You need to log in before you can comment on or make changes to this bug.