Bug 15281

Summary: WebKit hits ASSERT when attempting to drag an image from an SVG
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 15069, 15308    
Attachments:
Description Flags
the fix
none
fix, also fix --no-svg build on feature-branch
oliver: review+
updated patch for rebased feature-branch (mostly project file changes) oliver: review+

Description Eric Seidel (no email) 2007-09-25 12:42:52 PDT
WebKit hits ASSERT when attempting to drag an image from an SVG

In the end, this seems to have been due to a lack of [DOMSVGImageElement _subresources], which I implemented.  In order to make it work, I also had to export DOMSVG symbols from WebCore, as well as teach WebKit how to copy over the DOMSVG* header files into it's PrivateHeaders.
Comment 1 Eric Seidel (no email) 2007-09-25 13:07:32 PDT
Created attachment 16389 [details]
the fix
Comment 2 Eric Seidel (no email) 2007-09-25 14:30:33 PDT
Created attachment 16391 [details]
fix, also fix --no-svg build on feature-branch
Comment 3 David Kilzer (:ddkilzer) 2007-09-26 07:14:39 PDT
Comment on attachment 16391 [details]
fix, also fix --no-svg build on feature-branch

>+        This only affects Debug builds, and the ability to save SVGs as WebArchives
>+        neither are testable via DumpRenderTree.

I don't believe this statement is true.  It's possible for DRT to save pages as WebArchives now.  See the tests in the LayoutTests/webarchive/ directory.
Comment 4 Eric Seidel (no email) 2007-09-28 09:45:59 PDT
The problem SVG was similar to (but not identical to) this one:
http://people.mozilla.com/~vladimir/demos/photos.svg
Comment 5 Oliver Hunt 2007-10-01 19:13:38 PDT
This bugs was skipped when rebasing feature-branch and needs to be updated.
Comment 6 Eric Seidel (no email) 2007-10-01 22:16:07 PDT
Created attachment 16494 [details]
updated patch for rebased feature-branch (mostly project file changes)
Comment 7 Oliver Hunt 2007-10-01 22:19:45 PDT
Comment on attachment 16494 [details]
updated patch for rebased feature-branch (mostly project file changes)

rs=me
Comment 8 Eric Seidel (no email) 2007-10-01 22:29:41 PDT
Landed (again) as r25906.