Bug 152805

Summary: REGRESSION(r194613): JITMulGenerator needs a scratch GPR on 32-bit too.
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132470    
Attachments:
Description Flags
ROLLOUT of r194613
none
proposed patch. msaboff: review+

WebKit Commit Bot
Reported 2016-01-06 13:41:21 PST
http://trac.webkit.org/changeset/194613 broke the build: This change introduced 32-bit JSC test failures (Requested by ryanhaddad on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r194613 (27.48 KB, patch)
2016-01-06 13:41 PST, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
proposed patch. (1.93 KB, patch)
2016-01-06 14:13 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2016-01-06 13:41:55 PST
Created attachment 268400 [details] ROLLOUT of r194613 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Mark Lam
Comment 2 2016-01-06 14:13:34 PST
Created attachment 268405 [details] proposed patch.
Michael Saboff
Comment 3 2016-01-06 14:16:34 PST
Comment on attachment 268405 [details] proposed patch. r=me
Alexey Proskuryakov
Comment 4 2016-01-06 18:33:56 PST
Looks like the fix didn't pass EWS. Are the tests still failing?
Mark Lam
Comment 5 2016-01-06 18:36:17 PST
(In reply to comment #4) > Looks like the fix didn't pass EWS. Are the tests still failing? From the EWS bot: Error: mac-debug-ews unable to apply patch. 3 hours, 55 minutes ago Patch does not apply [results] 3 hours, 55 minutes ago Unable to pass tests without patch (tree is red?) [results] 3 hours, 56 minutes ago Looks like the fix worked: https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50
Mark Lam
Comment 6 2016-01-06 18:38:17 PST
Fix landed in r194669: <https://trac.webkit.org/r194669>.
Note You need to log in before you can comment on or make changes to this bug.