Bug 15278

Summary: Text highlight does a highlight around the entire run
Product: WebKit Reporter: George Staikos <staikos>
Component: TextAssignee: George Staikos <staikos>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Attachments:
Description Flags
A potential fix sullivan: review+

George Staikos
Reported 2007-09-25 10:12:00 PDT
The text highlight code in InlineTextBox.cpp:666 does a highlight of the entire run instead of the part we're searching for. Attached patch passes the missing parameters to select only the appropriate portions.
Attachments
A potential fix (603 bytes, patch)
2007-09-25 10:12 PDT, George Staikos 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
George Staikos
Comment 1 2007-09-25 10:12:48 PDT
Created attachment 16387 [details] A potential fix
John Sullivan
Comment 2 2007-09-25 15:03:34 PDT
Comment on attachment 16387 [details] A potential fix This fixes a bug in a code path that I wrote a long time ago for Safari's use, but which Safari no longer uses. r=me
George Staikos
Comment 3 2007-09-26 04:40:04 PDT
Checked in r25761
Note You need to log in before you can comment on or make changes to this bug.