Bug 152746

Summary: Web Inspector: DOMContentLoaded label in the Timeline tab should be "DOM Content Loaded"
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+, commit-queue: commit-queue-
[IMAGE] After none

Timothy Hatcher
Reported 2016-01-05 12:24:07 PST
The camel case should be expanded so it makes sense to localize. As-is it is "DOMContentLoaded" and marked for localization, which is confusing localizers. We should spell it out like we do other events in the Timeline tab.
Attachments
[PATCH] Proposed Fix (2.19 KB, patch)
2016-01-05 12:34 PST, Joseph Pecoraro 		timothy: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
[IMAGE] After (20.64 KB, image/png)
2016-01-05 12:34 PST, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-05 12:24:19 PST
<rdar://problem/24060780>
Joseph Pecoraro
Comment 2 2016-01-05 12:34:32 PST
Created attachment 268309 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-01-05 12:34:55 PST
Created attachment 268310 [details] [IMAGE] After
WebKit Commit Bot
Comment 4 2016-01-05 12:40:33 PST
Comment on attachment 268309 [details] [PATCH] Proposed Fix Rejecting attachment 268309 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 268309, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: imothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 283. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/654269
Joseph Pecoraro
Comment 5 2016-01-06 17:45:12 PST
<http://trac.webkit.org/changeset/194686>
Note You need to log in before you can comment on or make changes to this bug.