Bug 152737

Summary: [JSC] Get more of testb3 to pass on ARM64
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Benjamin Poulain 2016-01-05 10:38:03 PST
[JSC] Get more of testb3 to pass on ARM64
Comment 1 Benjamin Poulain 2016-01-05 10:40:08 PST
Created attachment 268289 [details]
Patch
Comment 2 Benjamin Poulain 2016-01-05 10:47:56 PST
Created attachment 268290 [details]
Patch
Comment 3 Geoffrey Garen 2016-01-05 10:52:04 PST
Last 500 characters of output:
sembler/AssemblerCommon.h:55:13: error: unused function 'isValidSignedImm9' [-Werror,-Wunused-function]
static bool isValidSignedImm9(int32_t value)
Comment 4 Benjamin Poulain 2016-01-05 12:22:10 PST
Created attachment 268305 [details]
Patch
Comment 5 Benjamin Poulain 2016-01-05 13:38:10 PST
Created attachment 268319 [details]
Patch
Comment 6 Benjamin Poulain 2016-01-05 14:21:40 PST
Comment on attachment 268319 [details]
Patch

Small stuffs.
Comment 7 Geoffrey Garen 2016-01-05 14:25:47 PST
Comment on attachment 268319 [details]
Patch

r=me
Comment 8 Filip Pizlo 2016-01-05 14:40:28 PST
Comment on attachment 268319 [details]
Patch

LGTM too
Comment 9 WebKit Commit Bot 2016-01-06 02:43:18 PST
Comment on attachment 268319 [details]
Patch

Clearing flags on attachment: 268319

Committed r194635: <http://trac.webkit.org/changeset/194635>
Comment 10 WebKit Commit Bot 2016-01-06 02:43:24 PST
All reviewed patches have been landed.  Closing bug.