Summary: | [mips] Lower immediates of logical operations. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konstantin Tokarev <annulen> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, guijemont, jbriance, keith_miller, mark.lam, msaboff, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Konstantin Tokarev
2016-01-04 09:50:46 PST
Created attachment 268200 [details]
Lower immediates of andi and andp
Comment on attachment 268200 [details] Lower immediates of andi and andp View in context: https://bugs.webkit.org/attachment.cgi?id=268200&action=review LGTM > Source/JavaScriptCore/offlineasm/mips.rb:525 > + when "andi", "andp" Please add other logical operations having this limitation (ori, orp, xori and xorp) Created attachment 268455 [details]
Patch
Great, thanks Michael, could you take a look at this? Comment on attachment 268455 [details]
Patch
r=me
Comment on attachment 268455 [details] Patch Clearing flags on attachment: 268455 Committed r194725: <http://trac.webkit.org/changeset/194725> All reviewed patches have been landed. Closing bug. *** Bug 150376 has been marked as a duplicate of this bug. *** (In reply to comment #3) > Created attachment 268455 [details] > Patch Sorry, I'm a bit late here ;). I understood that the andi, ori and xori instructions interpret the 16 bit immediate as unsigned, so I understand that we could use the instruction for the range 0x0..0xffff, and not only for 0x0..0x7fff. Or did I miss something? (In reply to comment #10) > Sorry, I'm a bit late here ;). I understood that the andi, ori and xori > instructions interpret the 16 bit immediate as unsigned, so I understand > that we could use the instruction for the range 0x0..0xffff, and not only > for 0x0..0x7fff. Or did I miss something? You're right. However if this case happens (immediate value in 0x7fff..0xffff), we'll also have to update the mipsOperand method of Immediate class to accept this range. Guillaume: you ar right, thanks for the gotcha. Julien: Immediate.mipsOperand allows -0x7fff <= value <= 0xffff, so it is already accepted. Reopening to attach new patch. Created attachment 269263 [details]
Patch
(In reply to comment #12) > Julien: Immediate.mipsOperand allows -0x7fff <= value <= 0xffff, so it is > already accepted. Indeed, I read too quickly :) Comment on attachment 269263 [details]
Patch
r=me
Comment on attachment 269263 [details] Patch Clearing flags on attachment: 269263 Committed r195290: <http://trac.webkit.org/changeset/195290> All reviewed patches have been landed. Closing bug. |