| Summary: | Rename scrollPosition(Scrollbar*) to scrollOffset(ScrollbarOrientation) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, bdakin, ddkilzer, ryanhaddad, simon.fraser, thorton, zalan | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2016-01-03 10:39:39 PST
Created attachment 268141 [details]
Patch
Created attachment 268145 [details]
Patch
Comment on attachment 268145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268145&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::ScrollView::scrollPosition): Deleted. Renamed > Source/WebCore/ChangeLog:24 > + (WebCore::RenderLayer::scrollPosition): Deleted. Renamed > Source/WebCore/ChangeLog:28 > + (WebCore::RenderListBox::scrollPosition): Deleted. Renamed (In reply to comment #4) > https://trac.webkit.org/changeset/194515 Looks like this broke the Windows build. Too bad you didn't wait for the EWS to finish? <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/74925> (In reply to comment #5) > (In reply to comment #4) > > https://trac.webkit.org/changeset/194515 > > Looks like this broke the Windows build. Too bad you didn't wait for the > EWS to finish? > > <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/ > builds/74925> c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\platform\win\PopupMenuWin.h(95): error C3668: 'WebCore::PopupMenuWin::scrollPosition': method with override specifier 'override' did not override any base class methods (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\PopupMenuWin.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\platform\win\PopupMenuWin.h(95): error C3668: 'WebCore::PopupMenuWin::scrollPosition': method with override specifier 'override' did not override any base class methods (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): error C2259: 'WebCore::PopupMenuWin': cannot instantiate abstract class [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): note: due to following members: C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): note: 'int WebCore::ScrollableArea::scrollOffset(WebCore::ScrollbarOrientation) const': is abstract C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ScrollableArea.h(149): note: see declaration of 'WebCore::ScrollableArea::scrollOffset' |