Bug 152666

Summary: Rename scrollPosition(Scrollbar*) to scrollOffset(ScrollbarOrientation)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bdakin, ddkilzer, ryanhaddad, simon.fraser, thorton, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2016-01-03 10:39:39 PST
Rename scrollPosition(Scrollbar*) to scrollOffset(ScrollbarOrientation)
Attachments
Patch (11.21 KB, patch)
2016-01-03 10:41 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (12.66 KB, patch)
2016-01-03 11:20 PST, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-01-03 10:41:06 PST
Created attachment 268141 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-01-03 11:20:35 PST
Created attachment 268145 [details] Patch
mitz
Comment 3 2016-01-03 11:24:08 PST
Comment on attachment 268145 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268145&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::ScrollView::scrollPosition): Deleted. Renamed > Source/WebCore/ChangeLog:24 > + (WebCore::RenderLayer::scrollPosition): Deleted. Renamed > Source/WebCore/ChangeLog:28 > + (WebCore::RenderListBox::scrollPosition): Deleted. Renamed
Simon Fraser (smfr)
Comment 4 2016-01-03 11:51:25 PST
https://trac.webkit.org/changeset/194515
David Kilzer (:ddkilzer)
Comment 5 2016-01-03 16:57:52 PST
(In reply to comment #4) > https://trac.webkit.org/changeset/194515 Looks like this broke the Windows build. Too bad you didn't wait for the EWS to finish? <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/74925>
David Kilzer (:ddkilzer)
Comment 6 2016-01-03 16:58:58 PST
(In reply to comment #5) > (In reply to comment #4) > > https://trac.webkit.org/changeset/194515 > > Looks like this broke the Windows build. Too bad you didn't wait for the > EWS to finish? > > <https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/ > builds/74925> c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\platform\win\PopupMenuWin.h(95): error C3668: 'WebCore::PopupMenuWin::scrollPosition': method with override specifier 'override' did not override any base class methods (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\PopupMenuWin.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\platform\win\PopupMenuWin.h(95): error C3668: 'WebCore::PopupMenuWin::scrollPosition': method with override specifier 'override' did not override any base class methods (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): error C2259: 'WebCore::PopupMenuWin': cannot instantiate abstract class [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): note: due to following members: C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\SearchPopupMenuWin.cpp(33): note: 'int WebCore::ScrollableArea::scrollOffset(WebCore::ScrollbarOrientation) const': is abstract C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\ScrollableArea.h(149): note: see declaration of 'WebCore::ScrollableArea::scrollOffset'
Simon Fraser (smfr)
Comment 7 2016-01-03 17:20:08 PST
Windows fixed in r194522.
Note You need to log in before you can comment on or make changes to this bug.