Bug 152649

Summary:

Some cleanup in ScrollAnimator

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, bugs-noreply, buildbot, cmarcelo, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jamesr, kondapallykalyan, luiz, mcatanzaro, rniwa, simon.fraser, thorton, tonikitoo, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews117 for mac-yosemite	none
Archive of layout-test-results from ews105 for mac-yosemite-wk2	none
Patch	none
Patch	zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
Patch	zalan: review+, commit-queue: commit-queue-

Simon Fraser (smfr)

Reported 2016-01-01 22:22:36 PST

Some cleanup in ScrollAnimator

Attachments
Patch (22.01 KB, patch) 2016-01-01 22:38 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-yosemite (744.61 KB, application/zip) 2016-01-01 23:29 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (757.79 KB, application/zip) 2016-01-01 23:33 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (796.98 KB, application/zip) 2016-01-01 23:34 PST, Build Bot	no flags	Details
Patch (23.49 KB, patch) 2016-01-01 23:38 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (928.39 KB, application/zip) 2016-01-02 00:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-yosemite (829.27 KB, application/zip) 2016-01-02 00:32 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (820.80 KB, application/zip) 2016-01-02 00:33 PST, Build Bot	no flags	Details
Patch (28.33 KB, patch) 2016-01-02 11:10 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (28.32 KB, patch) 2016-01-02 11:11 PST, Simon Fraser (smfr)	zalan: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (781.98 KB, application/zip) 2016-01-02 12:01 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (765.52 KB, application/zip) 2016-01-02 12:05 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (835.45 KB, application/zip) 2016-01-02 12:14 PST, Build Bot	no flags	Details
Patch (4.21 KB, patch) 2016-01-02 20:54 PST, Simon Fraser (smfr)	zalan: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-01-01 22:38:14 PST

Created attachment 268088 [details] Patch

Build Bot

Comment 2 2016-01-01 23:29:21 PST

Comment on attachment 268088 [details] Patch Attachment 268088 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/638226 New failing tests: scrollbars/scroll-rtl-or-bt-layer.html

Build Bot

Comment 3 2016-01-01 23:29:25 PST

Created attachment 268089 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-01-01 23:33:47 PST

Comment on attachment 268088 [details] Patch Attachment 268088 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/638238 New failing tests: scrollbars/scroll-rtl-or-bt-layer.html

Build Bot

Comment 5 2016-01-01 23:33:51 PST

Created attachment 268090 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-01-01 23:34:33 PST

Comment on attachment 268088 [details] Patch Attachment 268088 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/638225 New failing tests: scrollbars/scroll-rtl-or-bt-layer.html

Build Bot

Comment 7 2016-01-01 23:34:37 PST

Created attachment 268091 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Simon Fraser (smfr)

Comment 8 2016-01-01 23:38:51 PST

Created attachment 268092 [details] Patch

Build Bot

Comment 9 2016-01-02 00:28:50 PST

Comment on attachment 268092 [details] Patch Attachment 268092 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/638441 New failing tests: fast/scrolling/scroll-select-list.html

Build Bot

Comment 10 2016-01-02 00:28:56 PST

Created attachment 268095 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 11 2016-01-02 00:32:52 PST

Comment on attachment 268092 [details] Patch Attachment 268092 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/638417 New failing tests: fast/scrolling/scroll-select-list.html

Build Bot

Comment 12 2016-01-02 00:32:57 PST

Created attachment 268096 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 13 2016-01-02 00:33:01 PST

Comment on attachment 268092 [details] Patch Attachment 268092 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/638448 New failing tests: fast/dom/horizontal-scrollbar-in-rtl.html

Build Bot

Comment 14 2016-01-02 00:33:05 PST

Created attachment 268097 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Simon Fraser (smfr)

Comment 15 2016-01-02 11:10:21 PST

Created attachment 268105 [details] Patch

Simon Fraser (smfr)

Comment 16 2016-01-02 11:11:20 PST

Created attachment 268106 [details] Patch

Build Bot

Comment 17 2016-01-02 12:01:52 PST

Comment on attachment 268106 [details] Patch Attachment 268106 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/640503 New failing tests: fast/scrolling/scroll-select-list.html

Build Bot

Comment 18 2016-01-02 12:01:56 PST

Created attachment 268107 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 19 2016-01-02 12:05:37 PST

Comment on attachment 268106 [details] Patch Attachment 268106 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/640512 New failing tests: fast/dom/horizontal-scrollbar-in-rtl.html

Build Bot

Comment 20 2016-01-02 12:05:42 PST

Created attachment 268108 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 21 2016-01-02 12:14:18 PST

Comment on attachment 268106 [details] Patch Attachment 268106 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/640494 New failing tests: fast/scrolling/scroll-select-list.html

Build Bot

Comment 22 2016-01-02 12:14:22 PST

Created attachment 268109 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Simon Fraser (smfr)

Comment 23 2016-01-02 13:59:45 PST

https://trac.webkit.org/changeset/194502

Michael Catanzaro

Comment 24 2016-01-02 16:34:04 PST

This caused ~40 layout test failures on the GTK and EFL bots. :( A non-exhaustive list of tests that passed in r194501 but failed with r194502: fast/block/positioning/rtl-fixed-positioning.html [ Failure ] fast/block/positioning/vertical-rl/fixed-positioning.html [ Failure ] fast/css/text-overflow-ellipsis-bidi.html [ Failure ] fast/css/text-overflow-ellipsis-strict.html [ Failure ] fast/css/text-overflow-ellipsis-text-align-center.html [ Failure ] fast/css/text-overflow-ellipsis-text-align-justify.html [ Failure ] fast/css/text-overflow-ellipsis-text-align-left.html [ Failure ] fast/css/text-overflow-ellipsis-text-align-right.html [ Failure ] fast/css/text-overflow-ellipsis.html [ Failure ] fast/css/text-overflow-input.html [ Failure ] fast/css/vertical-text-overflow-ellipsis-text-align-center.html [ Failure ] fast/css/vertical-text-overflow-ellipsis-text-align-justify.html [ Failure ] fast/css/vertical-text-overflow-ellipsis-text-align-left.html [ Failure ] fast/css/vertical-text-overflow-ellipsis-text-align-right.html [ Failure ] fast/css/word-space-extra.html [ Failure ] fast/dom/horizontal-scrollbar-in-rtl.html [ Failure ] fast/dom/horizontal-scrollbar-when-dir-change.html [ Failure ] fast/dom/rtl-scroll-to-leftmost-and-resize.html [ Failure ] fast/dom/scroll-reveal-left-overflow.html [ Failure ] fast/dom/scroll-reveal-top-overflow.html [ Failure ] fast/dom/vertical-scrollbar-when-dir-change.html [ Failure ] fast/events/document-elementFromPoint.html [ Failure ] fast/events/offsetX-offsetY.html [ Failure ] fast/overflow/overflow-rtl-vertical-origin.html [ Failure ] fast/overflow/overflow-rtl-vertical.html [ Failure ] fast/overflow/overflow-rtl.html [ Failure ] fast/overflow/scroll-div-hide-show.html [ Failure ] fast/repaint/horizontal-bt-overflow-parent.html [ Failure ] fast/repaint/horizontal-bt-overflow-same.html [ Failure ] fast/repaint/vertical-overflow-parent.html [ Failure ] fast/repaint/vertical-overflow-same.html [ Failure ] fast/overflow/unreachable-overflow-rtl-bug.html [ Failure ] fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Failure ] fast/scrolling/programmatic-document-rtl-scrollIntoView.html [ Failure ] fast/scrolling/scroll-position-on-reload-rtl.html [ Failure ] fast/writing-mode/flipped-blocks-hit-test-overflow-scroll.html [ Failure ]

Michael Catanzaro

Comment 25 2016-01-02 16:46:18 PST

Full results: https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r194502 (12898)/results.html Some specific examples of breakage: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r194502%20(12898)/retries/fast/css/text-overflow-ellipsis-bidi-diffs.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r194502 (12898)/retries/fast/css/text-overflow-ellipsis-strict-diffs.html https://build.webkit.org/results/GTK Linux 64-bit Release (Tests)/r194502 (12898)/retries/fast/css/text-overflow-input-diffs.html

Simon Fraser (smfr)

Comment 26 2016-01-02 20:43:56 PST

Investigating.

Simon Fraser (smfr)

Comment 27 2016-01-02 20:54:11 PST

Created attachment 268124 [details] Patch

Simon Fraser (smfr)

Comment 28 2016-01-02 21:03:45 PST

Comment on attachment 268124 [details] Patch Landed in https://trac.webkit.org/changeset/194507, let's see if that fixes GTK.

WebKit Commit Bot

Comment 29 2016-01-02 22:11:19 PST

Comment on attachment 268124 [details] Patch Rejecting attachment 268124 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 268124, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 FAILED at 226. Hunk #2 FAILED at 235. Hunk #3 FAILED at 425. 3 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/ScrollAnimatorNone.cpp.rej patching file Source/WebCore/platform/ScrollAnimatorNone.h Hunk #1 FAILED at 107. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/ScrollAnimatorNone.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/642426

Michael Catanzaro

Comment 30 2016-01-03 08:07:33 PST

(In reply to comment #28) > Comment on attachment 268124 [details] > Patch > > Landed in https://trac.webkit.org/changeset/194507, let's see if that fixes > GTK. Still broken. :/

Simon Fraser (smfr)

Comment 31 2016-01-03 09:52:49 PST

I think https://trac.webkit.org/changeset/194513 should fix GTK. Waiting for a bot to tell me.

Michael Catanzaro

Comment 32 2016-01-03 10:32:56 PST

Thanks for working on this, Simon. r194513 fixed about 10 of the roughly 40 new failures.

Michael Catanzaro

Comment 33 2016-01-03 13:38:12 PST

Simon, your "minor cleanup" in r194516 fixed the remaining 30 failures. Thanks!

Simon Fraser (smfr)

Comment 34 2016-01-03 14:15:17 PST

Aha! Probably the "Do offset -> position conversion in ScrollAnimator::scrollToOffsetWithoutAnimation(). This is a behavior change, but I could never hit this code on Mac."

Michael Catanzaro

Comment 35 2016-01-03 19:31:18 PST

I am going to revert r194508 "Temporarily turn on Scrolling logging on GTK, to investigate" since it seems you've accidentally fixed our issue. ;)

Michael Catanzaro

Comment 36 2016-01-03 19:36:14 PST

Committed r194525: <http://trac.webkit.org/changeset/194525>

Gyuyoung Kim

Comment 37 2016-01-03 19:43:27 PST

(In reply to comment #33) > Simon, your "minor cleanup" in r194516 fixed the remaining 30 failures. > Thanks! EFL was fixed as well. Thanks. - https://build.webkit.org/builders/EFL Linux 64-bit Release WK2/builds/26128

Simon Fraser (smfr)

Comment 38 2016-01-03 20:09:25 PST

(In reply to comment #35) > I am going to revert r194508 "Temporarily turn on Scrolling logging on GTK, > to investigate" since it seems you've accidentally fixed our issue. ;) Ooops, thanks! I forgot about that.

Note You need to log in before you can comment on or make changes to this bug.