Bug 152567

Summary: [ANGLE][EFL][GTK] Remove 'template<class> class std::auto_ptr is deprecated' compile warning
Product: WebKit Reporter: Joonghun Park <jh718.park>
Component: ANGLEAssignee: Joonghun Park <jh718.park>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, dino, gyuyoung.kim, kondapallykalyan, ossy, roger_fong
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Joonghun Park 2015-12-27 05:35:59 PST
Remove 'template<class> class std::auto_ptr is deprecated' compile warning which is Angle related.

../../Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.h:83:10: warning: ‘template<class> class std::auto_ptr’ is deprecated [-Wdeprecated-declarations]
     std::auto_ptr<Token> mReserveToken;

Because auto_ptr is deprecated as of C++11, we should use unique_ptr instead.
Comment 1 Joonghun Park 2015-12-27 05:39:40 PST
Created attachment 267942 [details]
Patch
Comment 2 WebKit Commit Bot 2015-12-27 05:41:22 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 WebKit Commit Bot 2015-12-28 09:23:13 PST
Comment on attachment 267942 [details]
Patch

Clearing flags on attachment: 267942

Committed r194430: <http://trac.webkit.org/changeset/194430>
Comment 4 WebKit Commit Bot 2015-12-28 09:23:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2015-12-28 09:57:46 PST
Did anyone file an upstream bug for this, or is it already fixed upstream?
Comment 6 David Kilzer (:ddkilzer) 2015-12-28 10:04:46 PST
(In reply to comment #5)
> Did anyone file an upstream bug for this, or is it already fixed upstream?

Filed:  <https://bugs.chromium.org/p/angleproject/issues/detail?id=1269>
Comment 7 Joonghun Park 2015-12-28 18:21:01 PST
(In reply to comment #6)
> (In reply to comment #5)
> > Did anyone file an upstream bug for this, or is it already fixed upstream?
> 
> Filed:  <https://bugs.chromium.org/p/angleproject/issues/detail?id=1269>

Nice :) Thank you David.