Summary: | [CMake] Rearrange new gamepad files with deprecated files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, ap, bfulgham, commit-queue, ddkilzer, ryanhaddad | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2015-12-26 19:11:48 PST
Created attachment 267938 [details]
Patch
Created attachment 267940 [details]
Patch
Comment on attachment 267940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267940&action=review > Source/WebCore/CMakeLists.txt:3244 > + # FIXME: These were causing name conflicts on Mac, and the Gamepad API is not finished yet. This is probably not needed any more. That was to explain why I just commented out the files, but this clearly separated them in a way that's obvious what's going on. Created attachment 267941 [details]
Patch for landing
(In reply to comment #3) > Comment on attachment 267940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=267940&action=review > > > Source/WebCore/CMakeLists.txt:3244 > > + # FIXME: These were causing name conflicts on Mac, and the Gamepad API is not finished yet. > > This is probably not needed any more. That was to explain why I just > commented out the files, but this clearly separated them in a way that's > obvious what's going on. ok, let's remove it. Comment on attachment 267941 [details] Patch for landing Clearing flags on attachment: 267941 Committed r194424: <http://trac.webkit.org/changeset/194424> All reviewed patches have been landed. Closing bug. This appears to have broken the Windows Debug builds: <https://build.webkit.org/builders/Apple%20Win%20Debug%20(Build)?numbuilds=50> I'm not sure, but my guess is that we've exceeded a command-line character limit due to the sheer number of include (/I) switches and path lengths. I'm not sure how to fix this, though. First broken build: <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/92684> I'm trying a clean build. Hopefully that will magically fix everything. No magic this time, but http://trac.webkit.org/changeset/194434 fixed it. Turns out we only need a few parameters to assemble this super-simple file. Thanks for the heads-up, David! |