Bug 152562

Summary:

Simplify the test harness

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

Animations

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, dino, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+
1. Minor cleanup	none
2. Refactor the subclass pattern.	none
3. Make the class relationships more easily understandable	none
4. Get rid of stage.js, StageAnimator, and StageBenchmark	none
5. Refactor the simple suite.	none
6. Refactor miscellaneous suite.	none
7. Move example/ files into misc/.	none
8. Refactor the bouncing canvas tests.	none
9. Refactor the HTML suite.	none
10. Refactor the SVG suite.	none
11. Refactor the template.	none
12. Don't require new tests to pass a new instance of Animator	none
13. Will be checked in separately: update the simple canvas tests	none

Jon Lee

Reported 2015-12-26 10:38:09 PST

A few things: - Clean up some of the calls and return values, which are never used - Clarify the relationship between the benchmark, the stage, and the animator - Reduce the number of prototype jumps

Attachments
Patch (273.40 KB, patch) 2015-12-28 10:01 PST, Jon Lee	simon.fraser: review+	Details Formatted Diff Diff
1. Minor cleanup (8.70 KB, patch) 2015-12-28 10:05 PST, Jon Lee	no flags	Details Formatted Diff Diff
2. Refactor the subclass pattern. (146.67 KB, patch) 2015-12-28 10:05 PST, Jon Lee	no flags	Details Formatted Diff Diff
3. Make the class relationships more easily understandable (90.40 KB, patch) 2015-12-28 10:07 PST, Jon Lee	no flags	Details Formatted Diff Diff
4. Get rid of stage.js, StageAnimator, and StageBenchmark (25.30 KB, patch) 2015-12-28 10:08 PST, Jon Lee	no flags	Details Formatted Diff Diff
5. Refactor the simple suite. (15.85 KB, patch) 2015-12-28 10:08 PST, Jon Lee	no flags	Details Formatted Diff Diff
6. Refactor miscellaneous suite. (18.75 KB, patch) 2015-12-28 10:08 PST, Jon Lee	no flags	Details Formatted Diff Diff
7. Move example/ files into misc/. (23.87 KB, patch) 2015-12-28 10:09 PST, Jon Lee	no flags	Details Formatted Diff Diff
8. Refactor the bouncing canvas tests. (25.04 KB, patch) 2015-12-28 10:10 PST, Jon Lee	no flags	Details Formatted Diff Diff
9. Refactor the HTML suite. (19.37 KB, patch) 2015-12-28 10:10 PST, Jon Lee	no flags	Details Formatted Diff Diff
10. Refactor the SVG suite. (17.27 KB, patch) 2015-12-28 10:11 PST, Jon Lee	no flags	Details Formatted Diff Diff
11. Refactor the template. (11.48 KB, patch) 2015-12-28 10:11 PST, Jon Lee	no flags	Details Formatted Diff Diff
12. Don't require new tests to pass a new instance of Animator (15.80 KB, patch) 2015-12-28 10:12 PST, Jon Lee	no flags	Details Formatted Diff Diff
13. Will be checked in separately: update the simple canvas tests (8.21 KB, patch) 2015-12-28 10:12 PST, Jon Lee	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-12-26 10:38:27 PST

<rdar://problem/24011212>

Radar WebKit Bug Importer

Comment 2 2015-12-26 10:39:16 PST

<rdar://problem/24011215>

Jon Lee

Comment 3 2015-12-28 10:01:57 PST

Created attachment 267953 [details] Patch

Jon Lee

Comment 4 2015-12-28 10:05:23 PST

Created attachment 267954 [details] 1. Minor cleanup

Jon Lee

Comment 5 2015-12-28 10:05:44 PST

Created attachment 267955 [details] 2. Refactor the subclass pattern.

Jon Lee

Comment 6 2015-12-28 10:07:08 PST

Created attachment 267956 [details] 3. Make the class relationships more easily understandable

Jon Lee

Comment 7 2015-12-28 10:08:03 PST

Created attachment 267957 [details] 4. Get rid of stage.js, StageAnimator, and StageBenchmark

Jon Lee

Comment 8 2015-12-28 10:08:34 PST

Created attachment 267958 [details] 5. Refactor the simple suite.

Jon Lee

Comment 9 2015-12-28 10:08:54 PST

Created attachment 267959 [details] 6. Refactor miscellaneous suite.

Jon Lee

Comment 10 2015-12-28 10:09:59 PST

Created attachment 267960 [details] 7. Move example/ files into misc/.

Jon Lee

Comment 11 2015-12-28 10:10:39 PST

Created attachment 267961 [details] 8. Refactor the bouncing canvas tests.

Jon Lee

Comment 12 2015-12-28 10:10:56 PST

Created attachment 267962 [details] 9. Refactor the HTML suite.

Jon Lee

Comment 13 2015-12-28 10:11:34 PST

Created attachment 267963 [details] 10. Refactor the SVG suite.

Jon Lee

Comment 14 2015-12-28 10:11:50 PST

Created attachment 267964 [details] 11. Refactor the template.

Jon Lee

Comment 15 2015-12-28 10:12:14 PST

Created attachment 267965 [details] 12. Don't require new tests to pass a new instance of Animator

Jon Lee

Comment 16 2015-12-28 10:12:49 PST

Created attachment 267966 [details] 13. Will be checked in separately: update the simple canvas tests

Simon Fraser (smfr)

Comment 17 2015-12-31 20:36:05 PST

Comment on attachment 267953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267953&action=review > PerformanceTests/Animometer/tests/misc/resources/canvas-electrons.js:29 > + this._context.rotate(this._angle * Math.PI / 180); Probably worth having a deg2rad() helper somewhere. > PerformanceTests/ChangeLog:284 > - > + I don't think you should touch all the old changelog entries.

Jon Lee

Comment 18 2016-01-01 00:52:22 PST

Comment on attachment 267953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267953&action=review >> PerformanceTests/ChangeLog:284 >> + > > I don't think you should touch all the old changelog entries. Oof. My editor conveniently fixed all of the stray whitespace. I'll have to fix the diff. Also, shame on y'all.

Jon Lee

Comment 19 2016-01-03 15:03:36 PST

Committed r194520: <http://trac.webkit.org/changeset/194520>

Jon Lee

Comment 20 2016-01-03 15:06:08 PST

Committed r194521: <http://trac.webkit.org/changeset/194521>

Note You need to log in before you can comment on or make changes to this bug.