Bug 152538

Summary: [JSC] Bugfix for intrinsic getters with dictionary structures.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+
Benchmark results none

Keith Miller
Reported 2015-12-23 15:09:35 PST
[JSC] Bugfix for intrinsic getters with dictionary structures.
Attachments
Patch (5.82 KB, patch)
2015-12-23 15:15 PST, Keith Miller 		mark.lam: review+
DetailsFormatted DiffDiff
Benchmark results (64.89 KB, text/plain)
2015-12-23 15:35 PST, Keith Miller 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2015-12-23 15:15:59 PST
Created attachment 267857 [details] Patch
Mark Lam
Comment 2 2015-12-23 15:31:02 PST
Comment on attachment 267857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267857&action=review Do you have perf numbers to confirm no regression? > Source/JavaScriptCore/tests/stress/typedarray-length-dictionary.js:1 > +// This tests we do not intrinsic getters when the base structure is a dictionary. "tests *that* we do not *cache* intrinsic getters"?
Keith Miller
Comment 3 2015-12-23 15:34:44 PST
Comment on attachment 267857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267857&action=review There is no regression, I'll put the numbers up momentarily. >> Source/JavaScriptCore/tests/stress/typedarray-length-dictionary.js:1 >> +// This tests we do not intrinsic getters when the base structure is a dictionary. > > "tests *that* we do not *cache* intrinsic getters"? Fixed.
Mark Lam
Comment 4 2015-12-23 15:35:05 PST
Comment on attachment 267857 [details] Patch r=me if perf is good, and the test comment clarified.
Keith Miller
Comment 5 2015-12-23 15:35:28 PST
Created attachment 267870 [details] Benchmark results
Keith Miller
Comment 6 2015-12-23 15:45:42 PST
Committed r194400: <http://trac.webkit.org/changeset/194400>
Note You need to log in before you can comment on or make changes to this bug.