Summary: | [ES6] Arrow function. Default arguments in arrow functions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | GSkachkov <gskachkov> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, gskachkov, saam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 140855 | ||||||||||
Attachments: |
|
Description
GSkachkov
2015-12-23 13:33:38 PST
Created attachment 269476 [details]
Patch
Fix comments
Created attachment 269480 [details]
Patch
Add tests
Comment on attachment 269480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269480&action=review > LayoutTests/js/script-tests/arrowfunction-syntax.js:90 > +shouldBe("((x, y = 'default-value') => x + y)('input-value:')",'"input-value:default-value"'); you should add a test where you pass in: - "undefined" for y - anything that isn't undefined for y Created attachment 269564 [details]
Patch
Fix comments
Comment on attachment 269564 [details] Patch Clearing flags on attachment: 269564 Committed r195461: <http://trac.webkit.org/changeset/195461> All reviewed patches have been landed. Closing bug. |