Bug 152431 – Fix the !ENABLE(VIDEO) build after r192953 for <picture> element introduction

• Component: DOM
• Status: RESOLVED FIXED

[Olivier Blin]

Since r192953, HTMLSourceElement is built even if video is disabled, since it is used by the picture element.
 
But this breaks build with -no-video, since HTMLMediaElement usage should be guarded by VIDEO guards, and its JS bindings were still under a video conditional.

[Olivier Blin]

Created attachment 267637 [details]
Patch

[Alex Christensen]

Comment on attachment 267637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267637&action=review

> Source/WebCore/html/HTMLSourceElement.cpp:67
> +        else
> +#endif
> +        if (is<HTMLPictureElement>(*parent))

This is strange, but it's clear what is going on and has the correct behavior, and I can't make anything that does this that doesn't also look strange.

[Olivier Blin]

(In reply to comment #2)
> Comment on attachment 267637 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267637&action=review
> 
> > Source/WebCore/html/HTMLSourceElement.cpp:67
> > +        else
> > +#endif
> > +        if (is<HTMLPictureElement>(*parent))
> 
> This is strange, but it's clear what is going on and has the correct
> behavior, and I can't make anything that does this that doesn't also look
> strange.

This is indeed a bit weird, but I didn't find a better way, and saw that this pattern is already used in a few places, like HTMLOptionElement.cpp

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 267637 [details]
Patch

Clearing flags on attachment: 267637

Committed r194278: <http://trac.webkit.org/changeset/194278>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.