Bug 152428

Summary: [GTK] jquery.min.js violates DFSG
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Web InspectorAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, berto, cgarcia, commit-queue, graouts, joepeck, mattbaker, mcatanzaro, nvasilyev, timothy, webkit-bug-importer
Priority: P2    
Version: Other   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2015-12-18 09:16:24 PST
Debian is repackaging our tarballs with Source/WebInspectorUI/Tools/PrettyPrinting/populate/jquery.min.js removed, since it is a violation of the Debian Free Software Guidelines to distribute compressed code without the original source. A straightforward solution for GTK would be to simply not distribute Source/WebInspectorUI/Tools. I doubt we need any of that for the build, anyway, right?
Attachments
Patch (1.38 KB, patch)
2015-12-18 11:14 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-12-18 10:40:36 PST
Correct, Source/WebInspectorUI/Tools is not needed for the WebInspectorUI project to build. They are only debugging tools. Currently only one for pretty printing. WebInspectorUI's pretty printing debugging tool just loads the jquery.min.js text for testing JavaScript pretty printing. It was chosen because jquery.min.js was already in the LayoutTests directory. We could probably replace it with any significantly complex and minified JavaScript.
Michael Catanzaro
Comment 2 2015-12-18 11:10:19 PST
Well the issue is that it is minified; Debian requires us to ship the original source, not the minified source, and build the minified source from the original source. I think Fedora requires this too; we just didn't notice. Anyway, since it's just a debugging tool that has no value in tarballs, let's just not distribute it. Problem solved. :)
Michael Catanzaro
Comment 3 2015-12-18 11:14:49 PST
Created attachment 267644 [details] Patch
Michael Catanzaro
Comment 4 2015-12-18 11:18:11 PST
Although arguably, we could say this is a false-positive, in that even though it is source code, it's not source code that's intended to be run....
Joseph Pecoraro
Comment 5 2015-12-18 11:29:40 PST
Comment on attachment 267644 [details] Patch r=me
Michael Catanzaro
Comment 6 2015-12-18 15:27:32 PST
Thanks for the review. I'll wait a few days for Carlos to make sure he's OK with this.
Carlos Garcia Campos
Comment 7 2015-12-21 00:17:08 PST
Comment on attachment 267644 [details] Patch Yes, we only build files under UserInterface directory (and Localizations), so we don't need those files in the tarball at all.
WebKit Commit Bot
Comment 8 2015-12-21 01:05:06 PST
Comment on attachment 267644 [details] Patch Clearing flags on attachment: 267644 Committed r194327: <http://trac.webkit.org/changeset/194327>
WebKit Commit Bot
Comment 9 2015-12-21 01:05:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.