Bug 152417
| Summary: | Web Inspector: Implement console.timeline() and console.timelineEnd() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | All | ||
| OS: | All | ||
Nikita Vasilyev
Chrome DevTools and Firefox DevTools both support console.timeline() and console.timelineEnd().
console.timeline() starts timeline recording and console.timelineEnd() stops it.
https://twitter.com/addyosmani/status/487353570606743552
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
profile and profileEnd do that for us already. Though we can make these aliases or decide to change profile back.
Nikita Vasilyev
Chrome DevTools renamed console.timeline & console.timelineEnd to
console.time and console.timeEnd.
> console.timeline()
< 'console.timeline' is deprecated. Please use 'console.time' instead.
> console.timelineEnd()
< 'console.timelineEnd' is deprecated. Please use 'console.timeEnd' instead.
Radar WebKit Bug Importer
<rdar://problem/24356209>
Joseph Pecoraro
Hmm, we already use time/timeEnd for a high performance time measurement that already outputs to the console.
Nikita Vasilyev
(In reply to comment #4)
> Hmm, we already use time/timeEnd for a high performance time measurement
> that already outputs to the console.
Chrome's time/timeEnd does the same.
timeline/timelineEnd were removed when they switched to a tracing profiler in the
timelines.
https://code.google.com/p/chromium/issues/detail?id=412782
I find it to be a very bad developer experience. I hope we don't do the same
with profile/profileEnd.
Timothy Hatcher
(In reply to comment #5)
> (In reply to comment #4)
> > Hmm, we already use time/timeEnd for a high performance time measurement
> > that already outputs to the console.
>
> Chrome's time/timeEnd does the same.
>
> timeline/timelineEnd were removed when they switched to a tracing profiler
> in the
> timelines.
>
> https://code.google.com/p/chromium/issues/detail?id=412782
>
> I find it to be a very bad developer experience. I hope we don't do the same
> with profile/profileEnd.
They made that change due to architecture problems we don't have. I think we should make time/timeEnd markup the timeline like they do, and just keep profile/profileEnd as-is (start and stop the timeline.) I am hesitant to add timeline/timelineEnd as an alias of profile/rpofileEnd since Chrome deprecated it.
Blaze Burg
It seems this is not needed for parity, and it's redundant with existing API.