Bug 152401

Summary: Add types for DownloadID and TaskIdentifier
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 152414    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2015-12-17 15:34:44 PST
Add types for DownloadID and TaskIdentifier
Attachments
Patch (51.07 KB, patch)
2015-12-17 15:36 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.68 KB, patch)
2015-12-17 16:15 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.12 KB, patch)
2015-12-17 16:21 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.12 KB, patch)
2015-12-17 16:34 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-12-17 15:36:38 PST
Created attachment 267590 [details] Patch
Alex Christensen
Comment 2 2015-12-17 16:15:34 PST
Created attachment 267594 [details] Patch
Alex Christensen
Comment 3 2015-12-17 16:21:58 PST
Created attachment 267595 [details] Patch
Brady Eidson
Comment 4 2015-12-17 16:30:44 PST
Comment on attachment 267595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267595&action=review > Source/WebKit2/NetworkProcess/NetworkSession.h:34 > +#if PLATFORM(COCOA) > OBJC_CLASS NSURLSession; > OBJC_CLASS NSURLSessionDataTask; > OBJC_CLASS NSOperationQueue; > OBJC_CLASS WKNetworkSessionDelegate; > +#endif Seems unrelated to this patch. > Source/WebKit2/Shared/Downloads/DownloadID.h:42 > + DownloadID(uint64_t downloadID) explicit
Alex Christensen
Comment 5 2015-12-17 16:34:46 PST
Created attachment 267597 [details] Patch
Alex Christensen
Comment 6 2015-12-17 17:10:24 PST
http://trac.webkit.org/changeset/194250
WebKit Commit Bot
Comment 7 2015-12-17 18:45:05 PST
Re-opened since this is blocked by bug 152414
Alex Christensen
Comment 8 2015-12-17 23:56:56 PST
Comment on attachment 267597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267597&action=review > Source/WebKit2/Shared/Downloads/DownloadID.h:69 > + downloadID = WebKit::DownloadID(downloadID); This was always decoding downloadIDs of 0. It should actually use the value it decoded: downloadID = WebKit::DownloadID(id);
Alex Christensen
Comment 9 2015-12-18 00:12:13 PST
Fixed DownloadID.h target membership problem, fixed decoding problem, changed a few 0's to { }'s, and recommitted to http://trac.webkit.org/changeset/194264
Note You need to log in before you can comment on or make changes to this bug.