Summary: | Fix the debug region overlays for RTL documents | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bdakin, buildbot, commit-queue, rniwa, simon.fraser, thorton | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2015-12-16 18:26:34 PST
Created attachment 267520 [details]
Patch
Comment on attachment 267520 [details] Patch Attachment 267520 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/569435 New failing tests: imported/blink/fast/pagination/viewport-x-horizontal-tb-rtl.html fast/regions/selection/position-for-point-vert-rl.html fast/multicol/pagination/RightToLeft-tb.html imported/blink/fast/pagination/viewport-x-horizontal-bt-rtl.html imported/blink/fast/pagination/viewport-x-vertical-rl-rtl.html fast/multicol/vertical-rl/column-break-with-balancing.html fast/regions/selection/position-for-point-1-vert-rl.html fast/writing-mode/Kusa-Makura-background-canvas.html imported/blink/fast/pagination/viewport-x-vertical-rl-ltr.html fast/multicol/pagination/RightToLeft-lr.html fast/multicol/pagination/RightToLeft-bt.html fast/block/positioning/auto/vertical-rl/007.html fast/block/basic/truncation-rtl.html fast/multicol/pagination/RightToLeft-rl.html Created attachment 267524 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 267520 [details] Patch Attachment 267520 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/569448 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html Created attachment 267525 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 267528 [details]
Patch
Comment on attachment 267528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267528&action=review > Source/WebCore/page/PageOverlay.cpp:184 > + IntPoint offset = frameView->scrollOrigin(); I think this should be: auto& offset = frameView->scrollOrigin(); > Source/WebCore/page/PageOverlay.cpp:185 > + graphicsContext.translate(toFloatSize(frameView->scrollOrigin())); should be toFloatSize(offset) Created attachment 267535 [details]
Patch
Comment on attachment 267535 [details] Patch Clearing flags on attachment: 267535 Committed r194210: <http://trac.webkit.org/changeset/194210> All reviewed patches have been landed. Closing bug. |