Summary: | ARM64 MacroAssembler improperly reuses data temp register in test32() and test8() calls | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, saam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 151839 | ||||||
Attachments: |
|
Description
Michael Saboff
2015-12-16 17:55:29 PST
Created attachment 267516 [details]
Patch
Comment on attachment 267516 [details] Patch Clearing flags on attachment: 267516 Committed r194208: <http://trac.webkit.org/changeset/194208> All reviewed patches have been landed. Closing bug. Comment on attachment 267516 [details]
Patch
Does this work? Keith told me this doesn't work.
(In reply to comment #4) > Comment on attachment 267516 [details] > Patch > > Does this work? Keith told me this doesn't work. From my discussion with Keith, this is what he tried and it work. He was concerned that there were other issues, but I couldn't find any. My patch is working with this patch applied so this should be sufficient. |