Give kernel VM some hints about non-live memory-cached resources.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Andreas Kling]

We could improve our Good Citizen Score(tm) on the system by letting the kernel know that it's OK to reclaim clean file-backed pages for memory-cached resources that are not currently in use.

They would eventually get reclaimed anyway, but this patch will be about nudging them to the head of the eviction queue through madvise(MADV_DONTNEED).

[Andreas Kling]

Created attachment 267496 [details]
Patch

[Geoffrey Garen]

Comment on attachment 267496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267496&action=review

> Source/WebCore/platform/cf/SharedBufferCF.cpp:81
> +    OSAllocator::hintMemoryNotNeededSoon((void*)platformData(), platformDataSize());

I don't think you need a cast here? If you do need one, static_cast please.

[Build Bot]

Comment on attachment 267496 [details]
Patch

Attachment 267496 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/568817

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html

[Build Bot]

Created attachment 267507 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Andreas Kling]

Created attachment 267510 [details]
Patch for landing

[Andreas Kling]

Created attachment 267513 [details]
Patch for landing

With Windows fixed.

[WebKit Commit Bot]

Comment on attachment 267513 [details]
Patch for landing

Rejecting attachment 267513 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 267513, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Geoff Garen found in /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/569195

[Andreas Kling]

Created attachment 267515 [details]
Patch for landing

s/Geoff/Geoffrey/ :|

[WebKit Commit Bot]

Comment on attachment 267515 [details]
Patch for landing

Clearing flags on attachment: 267515

Committed r194204: <http://trac.webkit.org/changeset/194204>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.