Bug 152302

Summary: [JSC] SyntaxError if AssignmentElement is `eval` or `arguments` in strict code
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, ggaren, keith_miller, mark.lam, msaboff, sbarati, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Caitlin Potter (:caitp) 2015-12-15 08:52:03 PST
[JSC] SyntaxError if AssignmentElement is `eval` or `arguments` in strict code
Comment 1 Caitlin Potter (:caitp) 2015-12-15 08:54:11 PST
Created attachment 267373 [details]
Patch

 and  must not be assigned to in strict code. This change fixes  in Test262 (and a variety of other similar tests).
Comment 2 Mark Lam 2015-12-15 09:01:38 PST
Comment on attachment 267373 [details]
Patch

r=me
Comment 3 Caitlin Potter (:caitp) 2015-12-15 09:05:23 PST
Created attachment 267374 [details]
Patch
Comment 4 Mark Lam 2015-12-15 09:09:56 PST
Comment on attachment 267374 [details]
Patch

I see that this patch is identical to the last one with the exception of the reviewer name being added.  FYI, you don't have to upload a new patch just for that.  Just request a cq?.  Any committer / reviewer can cq+ the patch.  When the commit-queue commits, it will automatically fill in the reviewer's name.
Comment 5 Caitlin Potter (:caitp) 2015-12-15 09:12:00 PST
sorry, wasn't sure if people were filling that in manually like they would with dcommit or something.
Comment 6 WebKit Commit Bot 2015-12-15 09:58:30 PST
Comment on attachment 267374 [details]
Patch

Clearing flags on attachment: 267374

Committed r194107: <http://trac.webkit.org/changeset/194107>
Comment 7 WebKit Commit Bot 2015-12-15 09:58:33 PST
All reviewed patches have been landed.  Closing bug.